Bug #59057: rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test' - RADOS - Ceph

Actions

Copy link

Bug #59057

closed

rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test'

Added by Laura Flores about 1 year ago. Updated about 1 month ago.

Status:

Resolved

Priority:

High

Assignee:

Laura Flores

Category:

Target version:

% Done:

Source:

Tags:

backport_processed

Backport:

reef

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(RADOS):

Pull request ID:

52345

Crash signature (v1):

Crash signature (v2):

Description

/a/yuriw-2023-03-10_14:59:04-rados-wip-yuri4-testing-2023-03-09-1458-reef-distro-default-smithi/7201180

2023-03-10T19:05:12.850 INFO:tasks.workunit.client.0.smithi202.stdout:-- Found Git: /usr/bin/git (found version "2.39.1")
2023-03-10T19:05:12.979 INFO:tasks.workunit.client.0.smithi202.stderr:fatal: no tag exactly matches '473534bffa129e8f49e25c75020b0190d528572d'
2023-03-10T19:05:12.981 INFO:tasks.workunit.client.0.smithi202.stdout:-- JNI library is disabled
2023-03-10T19:05:13.033 INFO:tasks.workunit.client.0.smithi202.stdout:-- Configuring done
2023-03-10T19:05:13.425 INFO:tasks.workunit.client.0.smithi202.stdout:-- Generating done
2023-03-10T19:05:13.440 INFO:tasks.workunit.client.0.smithi202.stderr:CMake Warning:
2023-03-10T19:05:13.440 INFO:tasks.workunit.client.0.smithi202.stderr:  Manually-specified variables were not used by the project:
2023-03-10T19:05:13.440 INFO:tasks.workunit.client.0.smithi202.stderr:
2023-03-10T19:05:13.441 INFO:tasks.workunit.client.0.smithi202.stderr:    WITH_LIBRADOS
2023-03-10T19:05:13.441 INFO:tasks.workunit.client.0.smithi202.stderr:
2023-03-10T19:05:13.441 INFO:tasks.workunit.client.0.smithi202.stderr:
2023-03-10T19:05:13.441 INFO:tasks.workunit.client.0.smithi202.stdout:-- Build files have been written to: /home/ubuntu/cephtest/mnt.0/client.0/tmp/rocksdb/build
2023-03-10T19:05:13.450 INFO:tasks.workunit.client.0.smithi202.stderr:+ make rocksdb_env_librados_test -j8
2023-03-10T19:05:13.509 DEBUG:teuthology.orchestra.run:got remote process result: 2
2023-03-10T19:05:13.509 INFO:tasks.workunit.client.0.smithi202.stderr:make: *** No rule to make target 'rocksdb_env_librados_test'.  Stop.
2023-03-10T19:05:13.510 INFO:tasks.workunit:Stopping ['rados/test_envlibrados_for_rocksdb.sh'] on client.0...
2023-03-10T19:05:13.510 DEBUG:teuthology.orchestra.run.smithi202:> sudo rm -rf -- /home/ubuntu/cephtest/workunits.list.client.0 /home/ubuntu/cephtest/clone.client.0
2023-03-10T19:05:13.843 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Laura Flores about 1 year ago

Backport set to reef

Actions

Copy link

Updated by Radoslaw Zarzynski about 1 year ago

Priority changed from Normal to Urgent

Might be a fallout from the recent rocksdb upgrade. However, we started it pretty recently, after a bunch of successful runs. Were just lucky and was skipping the testcase (different random generator's seed?).

Actions

Copy link

Updated by Laura Flores about 1 year ago

@Radoslaw Smigielski it is not fallout from RocksDB. I found an example here from February:

/a/yuriw-2023-02-16_22:44:43-rados-wip-yuri-testing-2023-02-16-0839-distro-default-smithi/7177325

This test has quite a long history of failing in the rados suite. We previously talked about removing it since test_envlibrados_for_rocksdb doesn't have any users.

Actions

Copy link

Updated by Radoslaw Zarzynski about 1 year ago

Priority changed from Urgent to Normal

Thanks for info, Laura! Lowering the priority.

Actions

Copy link

Updated by Laura Flores about 1 year ago

Assignee set to Laura Flores

Actions

Copy link

Updated by Laura Flores about 1 year ago

/a/lflores-2023-03-27_02:17:31-rados-wip-aclamk-bs-elastic-shared-blob-save-25.03.2023-a-distro-default-smithi/7221159

Actions

Copy link

Updated by Laura Flores about 1 year ago

/a/yuriw-2023-03-14_20:10:47-rados-wip-yuri-testing-2023-03-14-0714-reef-distro-default-smithi/7207197

Actions

Copy link

Priority changed from Normal to High

High as it's a new thing in Reef.

Actions

Copy link

#16

Updated by Laura Flores 10 months ago

Did some digging for this. The script that sets up this test (qa/workunits/rados/test_envlibrados_for_rocksdb.sh in the ceph repo) clones the rocksdb repo at this commit: https://github.com/ceph/rocksdb/tree/9fa4990159853479a222244574ca41202e4c95c1

There is a file https://github.com/ceph/rocksdb/blob/master/utilities/env_librados_test.cc in the master branch that is important for building the "rocksdb_env_librados_test" target (also "env_libradoes_test is defined in https://github.com/ceph/rocksdb/blob/master/CMakeLists.txt). This file exists in the master branch, but not at the pinned commit.

It seems like there was perhaps a commit somewhere that removed this target.

Actions

Copy link

#17

Updated by Laura Flores 10 months ago

Found an explanation. In checking the git history between rocksdb v6.15.5 (commit c540de6f709b66efd41436694f72d6f7986a325b) and rocksdb v7.9.2 (commit 9fa4990159853479a222244574ca41202e4c95c1), several changes took place that moved the envlibrados tests to a different repo.

Still not sure how best to handle this for our test suite, but now we know why the env_librados files are missing.

git log --no-merges c540de6f709b66efd41436694f72d6f7986a325b..9fa4990159853479a222244574ca41202e4c95c1 utilities/env_librados.cc

commit fa523761176fd69e45aaa26e8e13e2e163177456
Author: Yanqin Jin <yanqin@fb.com>
Date:   Mon Jan 24 22:36:20 2022 -0800

    Move RADOS support to separate repo (#9206)

    Summary:
    This PR moves RADOS support from RocksDB repo to a separate repo. The new (temporary?) repo
    in this PR serves as an example before we finalize the decision on where and who to host RADOS support. At this point,
    people can start from the example repo and fork.

    The goal is to include this commit in RocksDB 7.0 release.

    Reference:
    https://github.com/ajkr/dedupfs by ajkr

    Pull Request resolved: https://github.com/facebook/rocksdb/pull/9206

    Test Plan:
    Follow instructions in https://github.com/riversand963/rocksdb-rados-env/blob/main/README.md and build
    test binary `env_librados_test` and run it.

    Also, make check

    Reviewed By: ajkr

    Differential Revision: D33751690

    Pulled By: riversand963

    fbshipit-source-id: 30466c62afa9e4619847a48567ed158e62835e35

commit 92e2399669df3fdc6c8573f9a4adf09e50a2796f
Author: Peter Dillinger <peterd@fb.com>
Date:   Fri Oct 29 08:17:24 2021 -0700

    Fix EnvLibrados and add to CI (#9088)

    Summary:
    This feature was not part of any common or CI build, so no
    surprise it broke. Now we can at least ensure compilation. I don't know
    how to run the test successfully (missing config file) so it is bypassed
    for now.

    Fixes https://github.com/facebook/rocksdb/issues/9078

    Pull Request resolved: https://github.com/facebook/rocksdb/pull/9088

    Test Plan: CI

    Reviewed By: mrambacher

    Differential Revision: D32009467

    Pulled By: pdillinger

    fbshipit-source-id: 3e0d1e5fde7f0ece703d48a81479e1cc7392c25c

Actions

Copy link

#18

Updated by Laura Flores 10 months ago

Status changed from New to In Progress

Actions

Copy link

#19

Updated by Laura Flores 10 months ago

Subject changed from rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test' on centos 8 to rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test'

Not specific to centos 8.

Actions

Copy link

#20