Project

General

Profile

Bug #58812

ceph-volume prepare doesn't use partitions as-is anymore

Added by Nicolas Lindae about 1 year ago. Updated 24 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
% Done:

0%

Source:
Community (user)
Tags:
backport_processed
Backport:
pacific quincy reef
Regression:
Yes
Severity:
3 - minor
Reviewed:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The is_device function in ceph-volume/util/disk.py is supposed to return false for partitions. This is later used to not create LVMs in the prepare command, see https://docs.ceph.com/en/quincy/ceph-volume/lvm/prepare/#ceph-volume-lvm-prepare:

For both block.db and block.wal, partitions can be used as-is, and therefore are not made into logical volumes.

This behavior changed with this commit: https://github.com/ceph/ceph/commit/5705e10e809cdc9f70018263c54a63ac4a02809c
Without lsblk, the stats fallback is used for partitions, and that happens to not work. So the bug was kind of hidden until this commit.

It's easy to test, you can copy the is_device and _stat_is_device and test them locally, they return true for my partitions. ceph-volume prepare therefore makes logical volumes on top of the partitions.


Related issues

Copied to ceph-volume - Backport #63598: quincy: ceph-volume prepare doesn't use partitions as-is anymore Resolved
Copied to ceph-volume - Backport #63599: reef: ceph-volume prepare doesn't use partitions as-is anymore Resolved
Copied to ceph-volume - Backport #63677: pacific: ceph-volume prepare doesn't use partitions as-is anymore Resolved

History

#1 Updated by Guillaume Abrioux 9 months ago

  • Status changed from New to In Progress
  • Assignee set to Teoman ONAY

#2 Updated by Teoman ONAY 5 months ago

  • Pull request ID set to 53798

#3 Updated by Guillaume Abrioux 3 months ago

  • Status changed from In Progress to Fix Under Review

#4 Updated by Guillaume Abrioux 3 months ago

  • Backport set to reef,quincy

#5 Updated by Guillaume Abrioux 3 months ago

  • Status changed from Fix Under Review to Pending Backport

#6 Updated by Backport Bot 3 months ago

  • Copied to Backport #63598: quincy: ceph-volume prepare doesn't use partitions as-is anymore added

#7 Updated by Backport Bot 3 months ago

  • Copied to Backport #63599: reef: ceph-volume prepare doesn't use partitions as-is anymore added

#8 Updated by Backport Bot 3 months ago

  • Tags set to backport_processed

#9 Updated by Konstantin Shalygin 3 months ago

  • Source set to Community (user)
  • Backport changed from reef,quincy to reef,quincy,quincy

#10 Updated by Konstantin Shalygin 3 months ago

  • Target version set to v19.0.0
  • Tags deleted (backport_processed)
  • Affected Versions v16.2.14, v17.2.7, v18.2.1 added
  • Affected Versions deleted (v17.2.5)

#11 Updated by Konstantin Shalygin 3 months ago

  • Backport changed from reef,quincy,quincy to pacific quincy reef

#12 Updated by Backport Bot 3 months ago

  • Copied to Backport #63677: pacific: ceph-volume prepare doesn't use partitions as-is anymore added

#13 Updated by Backport Bot 3 months ago

  • Tags set to backport_processed

#14 Updated by Guillaume Abrioux 24 days ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF