Actions
Bug #58812
closedceph-volume prepare doesn't use partitions as-is anymore
% Done:
0%
Source:
Community (user)
Tags:
backport_processed
Backport:
pacific quincy reef
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The is_device
function in ceph-volume/util/disk.py
is supposed to return false for partitions. This is later used to not create LVMs in the prepare command, see https://docs.ceph.com/en/quincy/ceph-volume/lvm/prepare/#ceph-volume-lvm-prepare:
For both block.db and block.wal, partitions can be used as-is, and therefore are not made into logical volumes.
This behavior changed with this commit: https://github.com/ceph/ceph/commit/5705e10e809cdc9f70018263c54a63ac4a02809c
Without lsblk, the stats fallback is used for partitions, and that happens to not work. So the bug was kind of hidden until this commit.
It's easy to test, you can copy the is_device and _stat_is_device and test them locally, they return true for my partitions. ceph-volume prepare
therefore makes logical volumes on top of the partitions.
Updated by Guillaume Abrioux 11 months ago
- Status changed from New to In Progress
- Assignee set to Teoman ONAY
Updated by Guillaume Abrioux 5 months ago
- Status changed from In Progress to Fix Under Review
Updated by Guillaume Abrioux 5 months ago
- Status changed from Fix Under Review to Pending Backport
Updated by Backport Bot 5 months ago
- Copied to Backport #63598: quincy: ceph-volume prepare doesn't use partitions as-is anymore added
Updated by Backport Bot 5 months ago
- Copied to Backport #63599: reef: ceph-volume prepare doesn't use partitions as-is anymore added
Updated by Konstantin Shalygin 5 months ago
- Source set to Community (user)
- Backport changed from reef,quincy to reef,quincy,quincy
Updated by Konstantin Shalygin 5 months ago
- Target version set to v19.0.0
- Tags deleted (
backport_processed) - Affected Versions v16.2.14, v17.2.7, v18.2.1 added
- Affected Versions deleted (
v17.2.5)
Updated by Konstantin Shalygin 5 months ago
- Backport changed from reef,quincy,quincy to pacific quincy reef
Updated by Backport Bot 5 months ago
- Copied to Backport #63677: pacific: ceph-volume prepare doesn't use partitions as-is anymore added
Updated by Guillaume Abrioux 3 months ago
- Status changed from Pending Backport to Resolved
Actions