Project

General

Profile

Actions

Bug #58591

closed

report "Insufficient space (<5GB)" even when disk size is sufficient

Added by Satoru Takeuchi about 1 year ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
% Done:

0%

Source:
Community (user)
Tags:
backport_processed
Backport:
quincy, pacific, reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph-volumes uses `/sys/block/<bdev>/size` field to judge whether a device has enough size (>= 5GiB).
The unit of this file is sector(=512 bytes), however, ceph-volume regards this value as byte by mistake.

https://github.com/ceph/ceph/blob/8e459c55f4d7afef71d5cdfcba01b9583fb3ff3e/src/ceph-volume/ceph_volume/util/device.py#L586

if int(self.sys_api.get('size', 0)) < 5368709120:

It should be 5368709120 / sector size

ref. Rook's issue.
Certain disks skipped for being too small, when they are large enough.
https://github.com/rook/rook/issues/11474

software versions:
- Rook: v1.10.7
- Ceph: v17.2.5


Related issues 3 (0 open3 closed)

Copied to ceph-volume - Backport #63311: pacific: report "Insufficient space (<5GB)" even when disk size is sufficientResolvedKonstantin ShalyginActions
Copied to ceph-volume - Backport #63312: reef: report "Insufficient space (<5GB)" even when disk size is sufficientResolvedKonstantin ShalyginActions
Copied to ceph-volume - Backport #63313: quincy: report "Insufficient space (<5GB)" even when disk size is sufficientResolvedKonstantin ShalyginActions
Actions #1

Updated by Guillaume Abrioux about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Guillaume Abrioux
Actions #2

Updated by Konstantin Shalygin 6 months ago

  • Status changed from In Progress to Pending Backport
  • Target version set to v19.0.0
  • Backport changed from quincy, pacific to quincy, pacific, reef
Actions #3

Updated by Backport Bot 6 months ago

  • Copied to Backport #63311: pacific: report "Insufficient space (<5GB)" even when disk size is sufficient added
Actions #4

Updated by Backport Bot 6 months ago

  • Copied to Backport #63312: reef: report "Insufficient space (<5GB)" even when disk size is sufficient added
Actions #5

Updated by Backport Bot 6 months ago

  • Copied to Backport #63313: quincy: report "Insufficient space (<5GB)" even when disk size is sufficient added
Actions #6

Updated by Backport Bot 6 months ago

  • Tags set to backport_processed
Actions #7

Updated by Konstantin Shalygin 5 months ago

  • Assignee deleted (Guillaume Abrioux)
  • Source set to Community (user)
  • Pull request ID set to 49954
Actions #8

Updated by Guillaume Abrioux 3 months ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF