Actions
Bug #58576
closeddo not allow invalid flags with cmd 'scrub start'
Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Correctness/Safety
Target version:
-
% Done:
0%
Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
scrub, task(easy)
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Currently, cmd 'scrub start' would accept any flag and looking at logs, it does actually start the scrubbing on the path mentioned.
$ ./bin/ceph tell mds.0 scrub start ~mdsdir foo
{
"return_code": 0,
"scrub_tag": "foo",
"mode": "asynchronous"
}
This needs to fixed, need to throw an error saying "flag is invalid".
Updated by Dhairya Parmar about 1 year ago
- Status changed from New to Rejected
- Assignee deleted (
Dhairya Parmar)
Alright so the cmd works as expected, it's just that the first arg it considers as scrub tag. If given more args then it would fail
$ ./bin/ceph tell mds.0 scrub start ~mdsdir foo foo1
Invalid command: unused arguments: ['foo1']
scrub start <path> [<scrubops:force|recursive|repair|scrub_mdsdir>...] [<tag>] : scrub and inode and output results
Error EINVAL: invalid command
Actions