Project

General

Profile

Cleanup #58561

cephfs-top: move FSTopBase to fstopbase.py

Added by Jos Collin 8 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code Hygiene
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
cephfs-top
Labels (FS):
Pull request ID:

Description

move FSTopBase to fstopbase.py and import it to cephfs-top script. This is easy to do. But the issue is when it's done, the teuthology tests (fs:top) fails with error:

2023-01-18T01:08:17.518 INFO:teuthology.orchestra.run.smithi033.stderr:  File "/usr/bin/cephfs-top", line 14, in <module>
2023-01-18T01:08:17.518 INFO:teuthology.orchestra.run.smithi033.stderr:    from fstopbase import FSTopBase, GLOBAL_METRICS_KEY, CLIENT_METADATA_KEY,\
2023-01-18T01:08:17.518 INFO:teuthology.orchestra.run.smithi033.stderr:ModuleNotFoundError: No module named 'fstopbase'

Tried modifying src/tools/cephfs/top/setup.py -> "scripts=" to include fstopbase.py. This works locally and puts fstopbase.py and cephfs-top scripts in the same install folder, but still this fix fails in teuthology. Updated debian/cephfs-top.install and python3-ceph-argparse.install to include fstopbase.py, but all these methods fail to find fstopbase.py in teuthology.

Also available in: Atom PDF