Project

General

Profile

Actions

Bug #58095

closed

snap-schedule: handle non-existent path gracefully during snapshot creation

Added by Milind Changire over 1 year ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Category:
Administration/Usability
Target version:
% Done:

0%

Source:
Tags:
backport_processed
Backport:
reef,quincy,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
fs
Component(FS):
mgr/snap_schedule
Labels (FS):
task(easy)
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The most common mistake that users tend to do is include the mount point path along with the file-system path when using snap-schedule commands.
This leads to the snap-schedule module encountering invalid paths as far as the file-system is concerned.


Related issues 3 (0 open3 closed)

Copied to CephFS - Backport #59016: quincy: snap-schedule: handle non-existent path gracefully during snapshot creationResolvedMilind ChangireActions
Copied to CephFS - Backport #59017: pacific: snap-schedule: handle non-existent path gracefully during snapshot creationResolvedMilind ChangireActions
Copied to CephFS - Backport #59411: reef: snap-schedule: handle non-existent path gracefully during snapshot creationResolvedMilind ChangireActions
Actions #1

Updated by Milind Changire over 1 year ago

  • ceph-qa-suite fs added
  • Component(FS) mgr/snap_schedule added
  • Labels (FS) task(easy) added
Actions #2

Updated by Milind Changire over 1 year ago

  • Assignee set to Milind Changire
Actions #3

Updated by Venky Shankar over 1 year ago

Milind Changire wrote:

The most common mistake that users tend to do is include the mount point path along with the file-system path when using snap-schedule commands.

Doesn't our documentation mention this clearly? If not, we should fix the doc.

This leads to the snap-schedule module encountering invalid paths as far as the file-system is concerned.

This was discussed as part of design with Jan - users can add schedules to non-existent file system paths, which may be created at a later point in time. Additionally, if the number of consecutive failures hit a certain configured value, the schedule would be deactivated for the path. Are you not seeing that?

Actions #4

Updated by Milind Changire over 1 year ago

Venky Shankar wrote:

Milind Changire wrote:

The most common mistake that users tend to do is include the mount point path along with the file-system path when using snap-schedule commands.

Doesn't our documentation mention this clearly? If not, we should fix the doc.

I'll look at the docs and put in a note there.

This leads to the snap-schedule module encountering invalid paths as far as the file-system is concerned.

This was discussed as part of design with Jan - users can add schedules to non-existent file system paths, which may be created at a later point in time. Additionally, if the number of consecutive failures hit a certain configured value, the schedule would be deactivated for the path. Are you not seeing that?

The schedule deactivation part is there, but there's no track kept of number of consecutive failures. The moment an exception get raised during snapshot creation, due to file-system or db updates, the schedule is set to inactive.

Actions #5

Updated by Milind Changire over 1 year ago

  • Subject changed from snap-schedule: validate path for all commands to snap-schedule: handle non-existent path gracefully during snapshot creation
Actions #6

Updated by Venky Shankar about 1 year ago

  • Category set to Administration/Usability
  • Target version set to v18.0.0
  • Backport set to pacific,quincy
  • Pull request ID set to 49102
Actions #7

Updated by Venky Shankar about 1 year ago

  • Status changed from New to Pending Backport
Actions #8

Updated by Backport Bot about 1 year ago

  • Copied to Backport #59016: quincy: snap-schedule: handle non-existent path gracefully during snapshot creation added
Actions #9

Updated by Backport Bot about 1 year ago

  • Copied to Backport #59017: pacific: snap-schedule: handle non-existent path gracefully during snapshot creation added
Actions #10

Updated by Backport Bot about 1 year ago

  • Tags set to backport_processed
Actions #11

Updated by Venky Shankar about 1 year ago

  • Tags deleted (backport_processed)
  • Backport changed from pacific,quincy to reef,quincy,pacific
Actions #12

Updated by Backport Bot about 1 year ago

  • Copied to Backport #59411: reef: snap-schedule: handle non-existent path gracefully during snapshot creation added
Actions #13

Updated by Backport Bot about 1 year ago

  • Tags set to backport_processed
Actions #14

Updated by Konstantin Shalygin 8 months ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF