Project

General

Profile

Bug #58095

snap-schedule: handle non-existent path gracefully during snapshot creation

Added by Milind Changire 2 months ago. Updated 2 months ago.

Status:
New
Priority:
Normal
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
fs
Component(FS):
mgr/snap_schedule
Labels (FS):
task(easy)
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The most common mistake that users tend to do is include the mount point path along with the file-system path when using snap-schedule commands.
This leads to the snap-schedule module encountering invalid paths as far as the file-system is concerned.

History

#1 Updated by Milind Changire 2 months ago

  • ceph-qa-suite fs added
  • Component(FS) mgr/snap_schedule added
  • Labels (FS) task(easy) added

#2 Updated by Milind Changire 2 months ago

  • Assignee set to Milind Changire

#3 Updated by Venky Shankar 2 months ago

Milind Changire wrote:

The most common mistake that users tend to do is include the mount point path along with the file-system path when using snap-schedule commands.

Doesn't our documentation mention this clearly? If not, we should fix the doc.

This leads to the snap-schedule module encountering invalid paths as far as the file-system is concerned.

This was discussed as part of design with Jan - users can add schedules to non-existent file system paths, which may be created at a later point in time. Additionally, if the number of consecutive failures hit a certain configured value, the schedule would be deactivated for the path. Are you not seeing that?

#4 Updated by Milind Changire 2 months ago

Venky Shankar wrote:

Milind Changire wrote:

The most common mistake that users tend to do is include the mount point path along with the file-system path when using snap-schedule commands.

Doesn't our documentation mention this clearly? If not, we should fix the doc.

I'll look at the docs and put in a note there.

This leads to the snap-schedule module encountering invalid paths as far as the file-system is concerned.

This was discussed as part of design with Jan - users can add schedules to non-existent file system paths, which may be created at a later point in time. Additionally, if the number of consecutive failures hit a certain configured value, the schedule would be deactivated for the path. Are you not seeing that?

The schedule deactivation part is there, but there's no track kept of number of consecutive failures. The moment an exception get raised during snapshot creation, due to file-system or db updates, the schedule is set to inactive.

#5 Updated by Milind Changire 2 months ago

  • Subject changed from snap-schedule: validate path for all commands to snap-schedule: handle non-existent path gracefully during snapshot creation

Also available in: Atom PDF