Bug #58000
closedmds: switch submit_mutex to fair mutex for MDLog
0%
Description
The implementations of the Mutex (e.g. std::mutex in C++) do not
guarantee fairness, they do not guarantee that the lock will be
acquired by threads in the order that they called the lock().
In most case this works well, but in overload case the client
requests handling thread and _submit_thread could always successfully
acquire the submit_mutex in a long time, which could make the
MDLog::trim() get stuck. That means the MDS daemons will fill journal
logs into the metadata pool, but couldn't trim the expired segments
in time.
This will switch the submit_mutex to fair mutex and it could make
sure that the all the submit_mutex waiters are in FIFO order and
could get a change to be excuted in time.
Updated by Xiubo Li over 1 year ago
From Patrick's comment in https://github.com/ceph/ceph/pull/44180#pullrequestreview-1174516711.
Updated by Venky Shankar over 1 year ago
- Category set to Correctness/Safety
- Status changed from New to Fix Under Review
- Assignee set to Xiubo Li
- Target version set to v18.0.0
- Backport set to pacific,quincy
Updated by Venky Shankar over 1 year ago
- Status changed from Fix Under Review to Pending Backport
Updated by Backport Bot over 1 year ago
- Copied to Backport #58343: pacific: mds: switch submit_mutex to fair mutex for MDLog added
Updated by Backport Bot over 1 year ago
- Copied to Backport #58344: quincy: mds: switch submit_mutex to fair mutex for MDLog added
Updated by Xiubo Li about 1 year ago
- Status changed from Pending Backport to Resolved