Project

General

Profile

Cleanup #58

kill nstring/cstring, use std::basic_string instead

Added by Sage Weil over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

I created cstring because the stl spec says that c_str() may be a temporary value, i assumed because the string wasn't stored with a null terminator. Looking at the gnu basic_string implementation that doesn't seem to be the case, which means we can probably just kill it. Unless there are other issues?

Associated revisions

Revision 3c081332 (diff)
Added by Joshua C. Randall over 1 year ago

fix panic when writing empty objects

fixes #58

History

#1 Updated by Sage Weil over 9 years ago

  • Status changed from New to Resolved

commit:ff8abee39f55e4222049145974a37fb395fba6ed

#2 Updated by Sage Weil over 9 years ago

  • Status changed from Resolved to 7

you can't give std::string() a NULL char * ... hopefully i found them all!

#3 Updated by Sage Weil over 9 years ago

  • Status changed from 7 to Resolved

Also available in: Atom PDF