Project

General

Profile

Actions
Copy link

Cleanup #57957

open

cephadm: rename "extra_container_args"

Added by Adam King over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

we ideally want a different name that makes it more clear that these are arguments for the podman/docker run command itself and NOT args to be added to the entrypoint/whatever is running within the container. So far the idea mentioned was "runtime_args". Whenever we have a new name we should probably alias extra_container_args to that new name to not break existing deployments while converting all documentation to use the new term.

Actions
Copy link
 #1

Updated by Adam King over 1 year ago

  • Subject changed from cephadm: rename "extra_ctonainer_args" to cephadm: rename "extra_container_args"
Actions
Copy link
 #2

Updated by John Mulligan over 1 year ago

Additionally, the "args" field specific to Custom Containers. I think that "args" is an attractively named option for someone looking to add args to the entrypoint. Doubly so for someone with a kubernetes background because that's what it does in k8s.

Actions
Copy link

Also available in: Atom PDF