Project

General

Profile

Bug #57893

make-dist creates ceph.spec with incorrect Release tag for SUSE-based distros

Added by Tim Serong 3 months ago. Updated 3 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph.spec.in says:

Name:           ceph
Version:        @PROJECT_VERSION@
Release:        @RPM_RELEASE@%{?dist}
%if 0%{?fedora} || 0%{?rhel}
Epoch:          2
%endif

When the make-dist script generates the final ceph.spec file for RPM builds, it will set PROJECT_VERSION to the version from the latest tag (e.g.: 17.0.0), and set RPM_RELEASE to the number of additional commits plus the last commit hash (e.g.: 14883.gc49b81c7d61). This doesn't work properly when building in SUSE's Open Build Service, because OBS overwrites the Release tag with checkin and build counters (see https://en.opensuse.org/openSUSE:Package_versioning_guidelines).

We've long carried a downstream patch for make-dist to fix this, by putting everything in PROJECT_VERSION, so you end up with something like Version: 17.0.0.14883+gc49b81c7d61 (see https://github.com/SUSE/ceph/commit/9ee636cdca3), so I figure I should really submit that upstream.


Related issues

Copied to Ceph - Backport #57916: quincy: make-dist creates ceph.spec with incorrect Release tag for SUSE-based distros In Progress

History

#1 Updated by Tim Serong 3 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 48547

#2 Updated by Tim Serong 3 months ago

  • Status changed from Fix Under Review to Pending Backport

#3 Updated by Backport Bot 3 months ago

  • Copied to Backport #57916: quincy: make-dist creates ceph.spec with incorrect Release tag for SUSE-based distros added

#4 Updated by Backport Bot 3 months ago

  • Tags set to backport_processed

Also available in: Atom PDF