Project

General

Profile

Actions
Copy link

Bug #57759

closed

crimson: rbdv1 needs TMAP, easier to implement than to skip rbdv1 tests

Added by Samuel Just over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Samuel Just
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

2022-10-02T17:42:42.419 INFO:tasks.workunit.client.0.smithi003.stdout:[ RUN      ] TestLibRBD.CreateAndStat
2022-10-02T17:42:43.525 INFO:tasks.workunit.client.0.smithi003.stdout:using old format
2022-10-02T17:42:45.662 INFO:tasks.workunit.client.0.smithi003.stdout:/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/18.0.0-218-g763de695/rpm/el8/BUILD/ceph-18.0.0-218-g763de695/src/test/librbd/test_librbd.cc:759: Failure
2022-10-02T17:42:45.663 INFO:tasks.workunit.client.0.smithi003.stdout:Expected equality of these values:
2022-10-02T17:42:45.663 INFO:tasks.workunit.client.0.smithi003.stdout:  0
2022-10-02T17:42:45.663 INFO:tasks.workunit.client.0.smithi003.stdout:  create_image(ioctx, name.c_str(), size, &order)
2022-10-02T17:42:45.664 INFO:tasks.workunit.client.0.smithi003.stdout:    Which is: -95
2022-10-02T17:42:45.664 INFO:tasks.workunit.client.0.smithi003.stdout:[  FAILED  ] TestLibRBD.CreateAndStat (3242 ms)

DEBUG 2022-10-02 17:42:45,578 [shard 0] osd - client_request(id=596, detail=m=[osd_op(client.4183.0:6 3.1c 3:3831950c:::rbd_directory:head {tmapup in=15b} snapc 0={} ondisk+write+known_if_redirected+supports_pool_eio e17) v8]): got obc lock
DEBUG 2022-10-02 17:42:45,578 [shard 0] osd - with_head_obc 3:3831950c:::rbd_directory:head
DEBUG 2022-10-02 17:42:45,578 [shard 0] osd - with_head_obc: found 3:3831950c:::rbd_directory:head in cache
DEBUG 2022-10-02 17:42:45,578 [shard 0] osd - do_osd_ops client specified snapc seq=0 snaps=[]
DEBUG 2022-10-02 17:42:45,578 [shard 0] osd - do_osd_ops_execute: object 3:3831950c:::rbd_directory:head - handling op tmapup
DEBUG 2022-10-02 17:42:45,579 [shard 0] osd - handling op tmapup on object 3:3831950c:::rbd_directory:head
INFO  2022-10-02 17:42:45,579 [shard 0] osd - crimson explicitly does not support CEPH_OSD_OP_TMAPUP

  - workunit:
      clients:
        client.0:
        - rbd/test_librbd.sh

Apparently test_librbd.sh is sending TMAPUP?

Actions
Copy link
 #1

Updated by Samuel Just over 1 year ago

  • Subject changed from crimson: to crimson: I guess test_librbd.sh sends TMAPUP?
Actions
Copy link
 #2

Updated by Samuel Just over 1 year ago

src/test/librbd/test_librbd.cc

static int get_features(bool *old_format, uint64_t *features)
{
  const char *c = getenv("RBD_FEATURES");
  if (c && strlen(c) > 0) {
    stringstream ss;
    ss << c;
    ss >> *features;
    if (ss.fail())
      return -EINVAL;
    *old_format = false;
    cout << "using new format!" << std::endl;
  } else {
    *old_format = true;
    *features = 0;
    cout << "using old format" << std::endl;
  }

  return 0;
}

Need to disable creating v1 images for rbd...

Actions
Copy link
 #3

Updated by Samuel Just over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Samuel Just over 1 year ago

  • Project changed from Ceph to crimson
Actions
Copy link
 #5

Updated by Samuel Just over 1 year ago

  • Subject changed from crimson: I guess test_librbd.sh sends TMAPUP? to crimson: rbdv1 needs TMAP, easier to implement than to skip rbdv1 tests
  • Status changed from New to Resolved
Actions
Copy link

Also available in: Atom PDF