Project

General

Profile

Cleanup #57735

mgr/dashboard: improve visualization of disk availability

Added by Nizamudeen A 4 months ago. Updated 4 months ago.

Status:
New
Priority:
Normal
Category:
UX
Target version:
-
% Done:

0%

Tags:
Backport:
quincy, pacific
Reviewed:
Affected Versions:
Pull request ID:

Description

If the disk is not available we just show empty in the Available column of the Physical Disks page. Instead it should properly display what's the availability now.

For example you can see bottom. The first row is the intended behvaiour but the actual behvaiour is shown in the rest of the rows.

phydisk.png View (30.3 KB) Nizamudeen A, 09/30/2022 08:04 AM

History

#1 Updated by Nizamudeen A 4 months ago

  • Description updated (diff)

#2 Updated by Nizamudeen A 4 months ago

  • Backport changed from quincy to quincy, pacific

#3 Updated by Juan Miguel Olmo Martínez 4 months ago

Just a couple of suggestions
1. Instead False .. could it be shown "No"
2. In addition to the "available" field there is an explanation field called "Reject reasons" with information about "why is not available the devices", Could it possible to show this information as a "tip" (or in other way) in the available (field)?

Example in CLI:

bash-4.4$ ceph orch device ls
HOST                              PATH      TYPE  DEVICE ID   SIZE  AVAILABLE  REFRESHED  REJECT REASONS              
mykube1-master-0.karmalabs.local  /dev/vdb  hdd   None       10.7G  No         0s ago     Has BlueStore device label  
mykube1-master-0.karmalabs.local  /dev/vdc  hdd   None       10.7G  Yes        0s ago     
mykube1-worker-0.karmalabs.local  /dev/vdb  hdd   None       10.7G  No         0s ago     Has BlueStore device label  
mykube1-worker-0.karmalabs.local  /dev/vdc  hdd   None       10.7G  No         0s ago     Has BlueStore device label  
mykube1-worker-1.karmalabs.local  /dev/vdb  hdd   None       10.7G  No         0s ago     Has BlueStore device label  
mykube1-worker-1.karmalabs.local  /dev/vdc  hdd   None       10.7G  No         0s ago     Has BlueStore device label 

bash-4.4$ ceph orch device ls --format json
[{"addr": "mykube1-master-0.karmalabs.local", "devices": [{"available": false, "ceph_device": null, "created": "2022-09-30T08:56:32.511467Z", "device_id": null, "human_readable_type": "hdd", "lsm_data": {}, "lvs": [], "path": "/dev/vdb", "rejected_reasons": ["Has BlueStore device label"], ....

#4 Updated by Ernesto Puerta 4 months ago

Shouldn't we add the True label in case is available?

It'd be a bit noisy though, so if the condition that is more infrequent is the unavailable one... What about an "Unavailable" column, and a ✓ (check-mark icon) on the unavailable ones? The idea is to minimize as much as possible the visual "noise" and only add visual cues on the infrequent cases.

I was also wondering if we add somehow indicate that a disk is unavailable by graying it out or something that doesn't require an extra column (we should try to keep that number low: 5-7 columns max).

Also available in: Atom PDF