Ceph » rgw

Problem¶

Compiler warnings in s3select

How to reproduce¶

Under `ceph/build`, run:

ninja rgw -j$(nproc)

You should see this output:

[2108/2145] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_s3select.cc.o
In file included from ../src/s3select/include/s3select_oper.h:16,
                 from ../src/s3select/include/s3select.h:12,
                 from ../src/rgw/rgw_s3select_private.h:39,
                 from ../src/rgw/rgw_s3select.cc:4:
../src/s3select/include/s3select_parquet_intrf.h: In member function ‘arrow::Result<std::shared_ptr<arrow::Buffer> > arrow::io::ceph::ReadableFile::ReadableFileImpl::ReadBuffer(int64_t)’:
../src/s3select/include/s3select_parquet_intrf.h:592:21: warning: redundant move in return statement [-Wredundant-move]
  592 |     return std::move(buffer);
      |            ~~~~~~~~~^~~~~~~~
../src/s3select/include/s3select_parquet_intrf.h:592:21: note: remove ‘std::move’ call
../src/s3select/include/s3select_parquet_intrf.h: In member function ‘arrow::Result<std::shared_ptr<arrow::Buffer> > arrow::io::ceph::ReadableFile::ReadableFileImpl::ReadBufferAt(int64_t, int64_t)’:
../src/s3select/include/s3select_parquet_intrf.h:604:21: warning: redundant move in return statement [-Wredundant-move]
  604 |     return std::move(buffer);
      |            ~~~~~~~~~^~~~~~~~
../src/s3select/include/s3select_parquet_intrf.h:604:21: note: remove ‘std::move’ call