Project

General

Profile

Bug #57543

rgw: fix bool/int logic error when calling get_obj_head_ioctx

Added by J. Eric Ivancich over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Target version:
-
% Done:

100%

Source:
Tags:
backport_processed
Backport:
quincy,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

get_obj_head_ioctx returns an int where 0 indicates success. When called in RGWRados::check_disk_state the result was treated as a booleann with inverted logic.

This was already fixed in https://github.com/ceph/ceph/pull/44616 as part of a larger commit, but we should unify the codebase, so various backports are consistent.

Add additional logging.


Related issues

Copied to rgw - Backport #57648: quincy: rgw: fix bool/int logic error when calling get_obj_head_ioctx Resolved
Copied to rgw - Backport #57649: pacific: rgw: fix bool/int logic error when calling get_obj_head_ioctx Resolved

History

#1 Updated by J. Eric Ivancich over 1 year ago

  • Description updated (diff)

#2 Updated by J. Eric Ivancich over 1 year ago

  • Status changed from Fix Under Review to Pending Backport

#3 Updated by Backport Bot over 1 year ago

  • Copied to Backport #57648: quincy: rgw: fix bool/int logic error when calling get_obj_head_ioctx added

#4 Updated by Backport Bot over 1 year ago

  • Copied to Backport #57649: pacific: rgw: fix bool/int logic error when calling get_obj_head_ioctx added

#5 Updated by Backport Bot over 1 year ago

  • Tags set to backport_processed

#6 Updated by Konstantin Shalygin about 1 year ago

  • Tracker changed from Cleanup to Bug
  • Status changed from Pending Backport to Resolved
  • % Done changed from 0 to 100
  • Regression set to No
  • Severity set to 3 - minor

Also available in: Atom PDF