Project

General

Profile

Actions

Feature #5730

closed

Show what command is being executed

Added by Alfredo Deza over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
ceph-deploy
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

To improve the knowledge (and debugging) about what ceph-deploying is doing with ceph behind the scenes we should be outputting the actual remote command when performing an action.

Because the compiled functions are rather big, they usually contain a few of the subprocess calls within, which is convenient but problematic to be able to achieve an "display what is going on for every remote action".

One way to help with this is to create a 'backend' for remote actions. For example, lets take `mon create` that performs the following remote actions:

  • if path doesn't exist create it
  • if done path doesn't exist create it * if tmp path doesn't exist create it * write the monitor keyring * call ceph-mon --mkfs * unlink keyring * create done file
  • if init file doesn't exist, create it
  • start the ceph-mon daemon

That means we have 3 items at the very minimum and 9 at the most, but all of them could be smaller, contained, testable, and easier to tell the user what is some command about to do.

If they are all into one single function (as it is right now) this is non-trivial.

Actions #1

Updated by Ian Colle over 10 years ago

  • Tracker changed from Bug to Feature
Actions #2

Updated by Alfredo Deza over 10 years ago

  • Status changed from New to Resolved

There was not a specific pull request for this since it was included as part of a bigger refactoring.

The new modules added into ceph-deploy have made `ceph-deploy install` be granular in a per-command basis for example.

Actions

Also available in: Atom PDF