Bug #573: monmaptool fails to parse IPv6 address - Messengers - Ceph

Actions

Copy link

Bug #573

closed

monmaptool fails to parse IPv6 address

Added by Wido den Hollander over 13 years ago. Updated about 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Wido den Hollander

Category:

Target version:

% Done:

50%

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

I'm trying to setup a small cluster with IPv6, but mkcephfs fails:

root@noisy:/etc/ceph# mkcephfs -c /etc/ceph/ceph.conf -a --mkbtrfs
/usr/bin/monmaptool --create --clobber --add noisy [2a00:f10:113:1:230:48ff:fe8d:a21f]:6789 --print /tmp/monmap.7552
/usr/bin/monmaptool: invalid ip:port '[2a00:f10:113:1:230:48ff:fe8d:a21f]:6789'
root@noisy:/etc/ceph#

It seems to be due to the lenght of the IPv6 address:

root@noisy:/etc/ceph# /usr/bin/monmaptool --create --clobber --add noisy [2a00:f10:113:1::48ff:fe8d:a21f]:6789 --print /tmp/monmap.7552
/usr/bin/monmaptool: monmap file /tmp/monmap.7552
/usr/bin/monmaptool: generated fsid 9db9ff4a-af74-ea19-cc52-9cd6e784af99
epoch 1
fsid 9db9ff4a-af74-ea19-cc52-9cd6e784af99
last_changed 2010-11-11 11:17:52.310828
created 2010-11-11 11:17:52.310828
0: [2a00:f10:113:1:0:48ff:fe8d:a21f]:6789/0 mon.noisy
/usr/bin/monmaptool: writing epoch 1 to /tmp/monmap.7552 (1 monitors)
root@noisy:/etc/ceph#

In this case I removed 230 and replaced it with ::

I've been searching through the source, but I can't find where the real parsing is done.

Files

0001-IPv6-Increase-buffer-for-address-parsing.patch (697 Bytes) 0001-IPv6-Increase-buffer-for-address-parsing.patch

Increase buffer space for IPv6 address including colon's

Wido den Hollander, 11/12/2010 04:56 AM

Actions

Copy link

Updated by Wido den Hollander over 13 years ago

Assignee set to Wido den Hollander
% Done changed from 0 to 50

Actions

Copy link

Updated by Wido den Hollander over 13 years ago

File 0001-IPv6-Increase-buffer-for-address-parsing.patch 0001-IPv6-Increase-buffer-for-address-parsing.patch added

After searching through the source I found it :)

Attached is a patch to fix the IPv6 address parsing. The buffer was 32 characters, that is indeed enough for the alpha-numeric characters in the address, but not the colon's in the IPv6 address.

Actions

Copy link