Project

General

Profile

Bug #57191

[cephadm] os tuned profile setting names are not validated from cephadm side

Added by Sunil Angadi 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
cephadm
Target version:
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

By setting wrong setting name which is not exist in sysctl option,
still cephadm tuned-profile apply command executed successfully
It should throw an error for the wrong setting name.

Tested in
ceph version 17.0.0-14295-g042ca579 (042ca579c2e4fece1853503d982b6afc0a0478dc) quincy (dev)

[ceph: root@magna086 /]# cat test-os-profile.yaml
profile_name: test-os-profile
placement:
hosts:
- magna086
- magna087
settings:
fs.file-max: 1000000
vm.swappiness: '30'
fs.aio-max-nr: 1048576
kernel.threads-max: 35511
wrong.dummy: 100

[ceph: root@magna086 /]# ceph orch tuned-profile apply -i test-os-profile.yaml
Saved tuned profile test-os-profile

wrong.dummy is not a valid os setting-name but ceph orch saved that profile.

History

#1 Updated by Redouane Kachach Elhichou 3 months ago

  • Status changed from New to In Progress
  • Assignee set to Redouane Kachach Elhichou

#2 Updated by Adam King 3 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 47787

#3 Updated by Adam King 3 months ago

this is now being covered as part of https://tracker.ceph.com/issues/57192 and is fixed in main and awaiting quincy backport

#4 Updated by Adam King 2 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF