Project

General

Profile

Actions

Cleanup #57153

open

src/pybind/mgr/tox.ini contains an redundant env 'lint'

Added by John Mulligan over 1 year ago. Updated over 1 year ago.

Status:
Fix Under Review
Priority:
Low
Assignee:
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

The tox.ini file used to run python unit tests and code quality tools has an item in the envlist called 'lint'. Since 'lint' is not a specific environment in the tox.ini it is basically redundant with the 'py3' env.

It's probable that this is a typo and should have been 'pylint' which is an env not listed in the envlist. However, I would not be inclined to enable the pylint job as it only checks one mgr module and it fails right now. We can manually run the pylint job with -e and fix it at a later time. Right now I'd prefer to speed up the run by removing 'lint'.

Assigning it to myself

Actions #1

Updated by Kefu Chai over 1 year ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 47808
Actions

Also available in: Atom PDF