Bug #57140
radosgw* no longer linked with libtcmalloc despite -DALLOCATOR=tcmalloc
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
2 - major
Reviewed:
Description
Following
https://tracker.ceph.com/issues/57050 -- Crash on startup of radosgw in librbd::rbd_features_from_string()
-->
https://github.com/ceph/ceph/pull/47504 -- rgw/cmake: stop building all of radosgw a shared lib #47504
bisect:
❯ git status
On branch main
Your branch is behind 'origin/main' by 347 commits, and can be fast-forwarded.
# ^^^
❯ git branch -vv
* main 41475848f53 [origin/main: behind 347] Merge pull request #47363 from tchaikov/boost-phoenix
❯ ldd ./build/bin/radosgw | grep libtc
libtcmalloc.so.4 => /lib64/libtcmalloc.so.4 (0x00007ffff59a0000)
❯ git bisect good
....
❯ ldd ./build/bin/radosgw | grep libtc
❯ git bisect bad
69a231888e05e4504e20e6a32506ed2a3c48d139 is the first bad commit
commit 69a231888e05e4504e20e6a32506ed2a3c48d139
Author: Casey Bodley <cbodley@redhat.com>
Date: Mon Aug 8 11:09:56 2022 -0700
rgw/cmake: stop building all of radosgw a shared lib
Fixes: https://tracker.ceph.com/issues/57050
Signed-off-by: Casey Bodley <cbodley@redhat.com>
ceph.spec.in | 3 ---
debian/radosgw.install | 1 -
src/CMakeLists.txt | 2 +-
src/rgw/CMakeLists.txt | 34 ++++++++--------------------------
src/rgw/radosgw.cc | 13 -------------
src/rgw/rgw_main.cc | 12 +-----------
src/test/CMakeLists.txt | 2 +-
7 files changed, 11 insertions(+), 56 deletions(-)
delete mode 100644 src/rgw/radosgw.cc
History
#1 Updated by Mark Kogan 8 months ago
- Pull request ID set to 47628
#2 Updated by Mark Kogan 8 months ago
after the fix also the shaman builds are linked with tcmalloc:
❯ wget "https://1.chacra.ceph.com/r/ceph/wip-fix-tcmalloc-link-i01/51fa31878e792669fc5aadc3b71b57313796d1f1/centos/8/flavors/default/x86_64/ceph-radosgw-17.0.0-14275.g51fa3187.el8.x86_64.rpm"
rpm2cpio ./ceph-radosgw-17.0.0-14275.g51fa3187.el8.x86_64.rpm | cpio -idmv
❯ ldd ./usr/bin/radosgw | grep libtc
libtcmalloc.so.4 => /lib64/libtcmalloc.so.4 (0x00007fffed59a000)
before the fix in for example
https://2.chacra.ceph.com/r/ceph/main/3f4ccb15825f50393727ddf25d0d19816a00bbdf/centos/8/flavors/crimson/x86_64/
checking 'ldd ./usr/bin/radosgw | grep libtc' -> 'libtcmalloc.so.4' is absent
#3 Updated by Casey Bodley 8 months ago
- Status changed from In Progress to Resolved