Bug #57106
openceph 17 fails to build with arrow 9
0%
Description
when trying to build ceph 17.2.3 with arrow 9 there are two types of errors:
/builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h:199:5: error: cannot convert 'arrow::internal::FileDescriptor' to 'int' in assignment
2669 199 | ARROW_ASSIGN_OR_RAISE(fd_, ::arrow::internal::FileOpenWritable(file_name_, write_only,
2670 | ^~~~~~~~~~~~~~~~~~~~~
2671 | |
2672 | arrow::internal::FileDescriptor
2673/builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h: In member function 'virtual arrow::Status arrow::io::OSFile::OpenReadable(const string&)':
2674/builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h:232:5: error: cannot convert 'arrow::internal::FileDescriptor' to 'int' in assignment
2675 232 | ARROW_ASSIGN_OR_RAISE(fd_, ::arrow::internal::FileOpenReadable(file_name_));
2676 | ^~~~~~~~~~~~~~~~~~~~~
2677 | |
2678 | arrow::internal::FileDescriptor
and
/builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h: In member function 'virtual std::unique_ptr<parquet::PageReader> parquet::ceph::SerializedRowGroup::GetColumnPageReader(int)':
2694/builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h:972:30: error: no matching function for call to 'parquet::PageReader::Open(std::shared_ptr<arrow::io::InputStream>&, int64_t, arrow::Compression::type, parquet::MemoryPool*, parquet::CryptoContext*)'
2695 972 | return PageReader::Open(stream, col->num_values(), col->compression(),
2696 | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2697 973 | properties_.memory_pool(), &ctx);
2698 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2699In file included from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h:17,
2700 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_oper.h:16,
2701 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select.h:12,
2702 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select_private.h:35,
2703 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select.cc:4:
2704/usr/include/parquet/column_reader.h:106:38: note: candidate: 'static std::unique_ptr<parquet::PageReader> parquet::PageReader::Open(std::shared_ptr<arrow::io::InputStream>, int64_t, arrow::Compression::type, bool, arrow::MemoryPool*, const parquet::CryptoContext*)'
2705 106 | static std::unique_ptr<PageReader> Open(
2706 | ^~~~
2707/usr/include/parquet/column_reader.h:109:28: note: no known conversion for argument 5 from 'parquet::CryptoContext*' to 'arrow::MemoryPool*'
2708 109 | ::arrow::MemoryPool* pool = ::arrow::default_memory_pool(),
2709 | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2710/usr/include/parquet/column_reader.h:111:38: note: candidate: 'static std::unique_ptr<parquet::PageReader> parquet::PageReader::Open(std::shared_ptr<arrow::io::InputStream>, int64_t, arrow::Compression::type, const parquet::ReaderProperties&, bool, const parquet::CryptoContext*)'
2711 111 | static std::unique_ptr<PageReader> Open(std::shared_ptr<ArrowInputStream> stream,
2712 | ^~~~
2713/usr/include/parquet/column_reader.h:113:67: note: no known conversion for argument 4 from 'parquet::MemoryPool*' {aka 'arrow::MemoryPool*'} to 'const parquet::ReaderProperties&'
2714 113 | const ReaderProperties& properties,
2715 | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
2716In file included from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_oper.h:16,
2717 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select.h:12,
2718 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select_private.h:35,
2719 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select.cc:4:
2720/builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h:987:28: error: no matching function for call to 'parquet::PageReader::Open(std::shared_ptr<arrow::io::InputStream>&, int64_t, arrow::Compression::type, parquet::MemoryPool*, parquet::CryptoContext*)'
2721 987 | return PageReader::Open(stream, col->num_values(), col->compression(),
2722 | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2723 988 | properties_.memory_pool(), &ctx);
2724 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2725In file included from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_parquet_intrf.h:17,
2726 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_oper.h:16,
2727 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select.h:12,
2728 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select_private.h:35,
2729 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select.cc:4:
2730/usr/include/parquet/column_reader.h:106:38: note: candidate: 'static std::unique_ptr<parquet::PageReader> parquet::PageReader::Open(std::shared_ptr<arrow::io::InputStream>, int64_t, arrow::Compression::type, bool, arrow::MemoryPool*, const parquet::CryptoContext*)'
2731 106 | static std::unique_ptr<PageReader> Open(
2732 | ^~~~
2733/usr/include/parquet/column_reader.h:109:28: note: no known conversion for argument 5 from 'parquet::CryptoContext*' to 'arrow::MemoryPool*'
2734 109 | ::arrow::MemoryPool* pool = ::arrow::default_memory_pool(),
2735 | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2736/usr/include/parquet/column_reader.h:111:38: note: candidate: 'static std::unique_ptr<parquet::PageReader> parquet::PageReader::Open(std::shared_ptr<arrow::io::InputStream>, int64_t, arrow::Compression::type, const parquet::ReaderProperties&, bool, const parquet::CryptoContext*)'
2737 111 | static std::unique_ptr<PageReader> Open(std::shared_ptr<ArrowInputStream> stream,
2738 | ^~~~
2739/usr/include/parquet/column_reader.h:113:67: note: no known conversion for argument 4 from 'parquet::MemoryPool*' {aka 'arrow::MemoryPool*'} to 'const parquet::ReaderProperties&'
2740 113 | const ReaderProperties& properties,
2741 | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
2742In file included from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select_oper.h:16,
2743 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/s3select/include/s3select.h:12,
2744 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select_private.h:35,
2745 from /builds/a16bitsysop/aports/testing/ceph17/src/ceph-17.2.3/src/rgw/rgw_s3select.cc:4:
The first error looks like it could be fixed with a static cast, but I am not sure about the second.
Updated by Duncan Bellamy over 1 year ago
this fixes building:
https://github.com/ceph/s3select/pull/112
not sure if its 100% correct
Updated by Kaleb KEITHLEY over 1 year ago
Gal Salomon was asked to review that patch and follow up with fixing it in the source at https://github.com/ceph/s3select/blob/master/include/s3select_parquet_intrf.h
Updated by Duncan Bellamy over 1 year ago
thanks, I couldn’t see any other trackers for arrow 9 or pull requests for it in ceph/s3select.
Updated by Gal Salomon over 1 year ago
I merged https://github.com/ceph/s3select/pull/112 (reviewed and tested)
the second issue(PageReader::Open) does not happen on my env.
checking that further. (probably compiler version)
Updated by Duncan Bellamy over 1 year ago
okay, thanks. Alpine recently update to gcc 12.1.1