Project

General

Profile

Bug #56671

zabbix module does not process some config options correctly

Added by Rafael Lopez 4 months ago. Updated 4 months ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
Category:
zabbix module
Target version:
% Done:

0%

Source:
Community (user)
Tags:
mgr,zabbix
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When changing config option for zabbix that is not host or port, zabbix returns failure message but seemingly succeeds:

root@soz-mon2:/# ceph-mgr --version
ceph version 17.2.1 (ec95624474b1871a821a912b8c3af68f8f8e7aa1) quincy (stable)
root@soz-mon2:/# 

root@soz-mon2:/# ceph zabbix config-show | grep interval
    "discovery_interval": 100,
    "interval": 60,
root@soz-mon2:/# ceph zabbix config-set interval 40
Failed to update configuration option interval
root@soz-mon2:/# ceph zabbix config-show | grep interval
    "discovery_interval": 100,
    "interval": "40",
root@soz-mon2:/# ceph zabbix config-set interval 60
Failed to update configuration option interval
root@soz-mon2:/# ceph zabbix config-show | grep interval
    "discovery_interval": 100,
    "interval": "60",
root@soz-mon2:/#

However after changing, it also fails later on when python is trying to use the value for it's interval:

Traceback (most recent call last):
  File "/usr/share/ceph/mgr/zabbix/module.py", line 313, in send
    zabbix.send(identifier, data)
  File "/usr/share/ceph/mgr/zabbix/module.py", line 48, in send
    raise RuntimeError('%s exited non-zero: %s' % (self.sender,
RuntimeError: /usr/bin/zabbix_sender exited non-zero: 
2022-07-22T01:00:24.520+0000 7fa48b531700  0 log_channel(cluster) log [DBG] : pgmap v33: 129 pgs: 129 active+clean; 642 MiB data, 2.9 GiB used, 597 GiB / 600 GiB avail
2022-07-22T01:00:24.520+0000 7fa4703fb700 -1 log_channel(cluster) log [ERR] : Unhandled exception from module 'zabbix' while running on mgr.soz-mon2: '>' not supported between instances of 'str' and 'int'
2022-07-22T01:00:24.524+0000 7fa4703fb700 -1 zabbix.serve:
2022-07-22T01:00:24.524+0000 7fa48b531700  0 log_channel(cluster) log [DBG] : pgmap v34: 129 pgs: 129 active+clean; 642 MiB data, 2.9 GiB used, 597 GiB / 600 GiB avail
2022-07-22T01:00:24.524+0000 7fa4703fb700 -1 Traceback (most recent call last):
  File "/usr/share/ceph/mgr/zabbix/module.py", line 465, in serve
    self.event.wait(interval)
  File "/lib/python3.9/threading.py", line 574, in wait
    signaled = self._cond.wait(timeout)
  File "/lib/python3.9/threading.py", line 315, in wait
    if timeout > 0:
TypeError: '>' not supported between instances of 'str' and 'int'

History

#3 Updated by Konstantin Shalygin 4 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Rafael Lopez
  • Source set to Community (user)
  • Pull request ID set to 47224

#4 Updated by Patrick Donnelly 4 months ago

  • Target version changed from v17.2.2 to v18.0.0

Also available in: Atom PDF