Project

General

Profile

Actions

Feature #5648

closed

mon should use 'module'/'perm' string in MonCommands.h for caps checking

Added by Dan Mick almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Category:
Monitor
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

'perm' was added to MonCommands.h for controlling GET vs PUT endpoints in ceph-rest-api;
however, it's also aimed at removing the fixed comparisons for monitor command permissions.

Replace things like session->is_capable("mds", MON_CAP_R) with something like "session->is_capable(cmdmap)"
which will look up cmdmap['prefix'] and find the module/required perms and compare the session caps
with it instead of the fixed MON_CAP_R.

Actions #1

Updated by Dan Mick almost 11 years ago

  • Tracker changed from Bug to Feature
Actions #2

Updated by Joao Eduardo Luis almost 11 years ago

  • Category set to Monitor
  • Status changed from New to In Progress
Actions #3

Updated by Sage Weil over 10 years ago

pushed wip-5648-b with some changes!

Actions #4

Updated by Sage Weil over 10 years ago

  • Status changed from In Progress to Resolved
Actions #5

Updated by Sage Weil over 10 years ago

merged post-dumpling; we can backport later if we feel like it.

Actions

Also available in: Atom PDF