Project

General

Profile

Bug #5639

librados: rados_monitor_log can drop messages

Added by Sage Weil over 10 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
librados
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

if we get a monitor session reset, and reconnect, we may have missed messages. a fix probably requires some tweaking to the version trhings provided to the mon subscribe mechanism

failures look like this: ubuntu@teuthology:/a/sage-bug-5626-d/67718

Associated revisions

Revision 510a1cc5 (diff)
Added by Radoslaw Zarzynski about 9 years ago

librados: fix message dropping in rados_monitor_log().

If the a librados client is disconnected from the monitor,
the reconnection procedure will be spawn. Among others,
it is responsible for renew of all monitor log subscriptions.
Unfortunately, the mechanism for restarting subscription
from next message after the last seen was inactive. Such
behaviour was caused by lack of updating MonClient control
structures via call like MonClient::sub_got().

Fixes: #5639
Signed-off-by: Radoslaw Zarzynski <>

History

#1 Updated by Greg Farnum over 10 years ago

  • Priority changed from High to Normal

#2 Updated by Radoslaw Zarzynski about 9 years ago

I am going to take care of this issue.

#3 Updated by Radoslaw Zarzynski about 9 years ago

Pull request is available here: https://github.com/ceph/ceph/pull/3632

#4 Updated by Sage Weil about 9 years ago

  • Status changed from New to Fix Under Review

#5 Updated by Sage Weil almost 7 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF