Project

General

Profile

Actions

Backport #56152

closed

pacific: mgr/snap_schedule: schedule updates are not persisted across mgr restart

Added by Milind Changire almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
High
Target version:
-
Release:
pacific
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/46797

scrub status does not reflect the correct status after mgr restart

eg.
Before restart mgrs:

[{"fs": "cephfs", "subvol": null, "path": "/", "rel_path": "/", "schedule": "1h", "retention": {"h": 6}, "start": "2022-06-07T12:50:00", "created": "2022-06-07T16:44:25", "first": "2022-06-07T16:50:00", "last": "2022-06-07T16:50:00", "last_pruned": null, "created_count": 1, "pruned_count": 0, "active": true}]
$ ceph fs snap-schedule status / --format=json

After Restart mgrs:

[{"fs": "cephfs", "subvol": null, "path": "/", "rel_path": "/", "schedule": "1h", "retention": {}, "start": "2022-06-07T12:50:00", "created": "2022-06-07T16:44:25", "first": null, "last": null, "last_pruned": null, "created_count": 0, "pruned_count": 0, "active": true}]
$ ceph fs snap-schedule status / --format=json

Need for this backport only tracker:
------------------------------------
* This issue needs to be fixed exclusively in the pacific branch since the db operations take place on the in-memory sqlite db and are not automatically persisted to permanent storage.
* This db management policy is older and different than the current mainline. In the mainline sources, the sqlite db uses the ceph backend to persist db changes directly to RADOS objects.
* Although there is a mechanism to write the in-memory db to the stable storage, the calls to the appropriate procedure needs to be added to functions which update the state of the db.
Actions #1

Updated by Milind Changire almost 2 years ago

  • Assignee set to Milind Changire
  • Priority changed from Normal to High
  • Pull request ID set to 46797
  • Affected Versions v16.2.8 added
  • Component(FS) mgr/snap_schedule added
Actions #2

Updated by Milind Changire almost 2 years ago

  • Subject changed from pacific: mgr/snap_schedule: schedule updates are not persisted across mgr restart to mgr/snap_schedule: schedule updates are not persisted across mgr restart
  • Backport set to pacific
Actions #3

Updated by Milind Changire almost 2 years ago

  • Tracker changed from Bug to Backport
  • Subject changed from mgr/snap_schedule: schedule updates are not persisted across mgr restart to pacific: mgr/snap_schedule: schedule updates are not persisted across mgr restart
  • Description updated (diff)
  • Release set to pacific
Actions #4

Updated by Milind Changire almost 2 years ago

  • Description updated (diff)
Actions #5

Updated by Venky Shankar almost 2 years ago

Milind, This is pacific only due to the usage of libsqlite in mainline vs in-memory+rados dump in pacfic?

Actions #6

Updated by Venky Shankar almost 2 years ago

Venky Shankar wrote:

Milind, This is pacific only due to the usage of libsqlite in mainline vs in-memory+rados dump in pacfic?

Never mind - I missed reading the last part of the description. It is the difference. Thx for putting that up.

Actions #7

Updated by Venky Shankar almost 2 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
Actions #9

Updated by Venky Shankar over 1 year ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF