Project

General

Profile

Actions

Bug #55775

open

`ceph-backport.sh` cannot determine upstream remote with excess forward slash chars

Added by Michael Fritch almost 2 years ago. Updated almost 2 years ago.

Status:
Fix Under Review
Priority:
Normal
Category:
scripts
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Following the documentation found here:
https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#opening-a-backport-pr

If the upstream remote happens to have any extra forward slash chars:

git@github.com:/ceph/ceph
https:///github.com/ceph/ceph

The ceph-backport.sh script is unable to determine the upstream remote:

$ git remote -v | grep upstream
upstream        git@github.com:/ceph/ceph (fetch)
upstream        git@github.com:/ceph/ceph (push)

$ alias ceph-backport="bash <(git --git-dir=`pwd`/.git --no-pager show upstream/main:src/script/ceph-backport.sh)" 

$ ceph-backport --setup
63: my GitHub username is mgfritch
63: ERROR: Cannot auto-determine upstream remote
/dev/fd/63: line 1280: (Could not find any upstream remote in "git remote -v"): command not found

Actions #1

Updated by Michael Fritch almost 2 years ago

  • Pull request ID set to 46405
Actions #2

Updated by Michael Fritch almost 2 years ago

  • Status changed from New to Fix Under Review
Actions

Also available in: Atom PDF