Project

General

Profile

Bug #55762

mgr/volumes: Handle internal metadata directories under '/volumes' properly.

Added by Kotresh Hiremath Ravishankar 6 months ago. Updated 3 months ago.

Status:
Pending Backport
Priority:
Normal
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Tags:
backport_processed
Backport:
quincy, pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

1) The subvolumegroup ls lists `_index` directory as subvolumegroup

# bin/ceph fs subvolumegroup ls a
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2022-05-25T12:28:24.565+0530 7f2eb7c03700 -1 WARNING: all dangerous and experimental features are enabled.
2022-05-25T12:28:24.573+0530 7f2eb7c03700 -1 WARNING: all dangerous and experimental features are enabled.
[
    {
        "name": "_nogroup" 
    },
    {
        "name": "_index" 
    }
]
root@kotresh-T490s:~/sandbox/kotresh-ceph/ceph/build# 

The `_index` directory should be filtered.

2) The subvolume ls with internal directories as group_name lists contents inside.

# bin/ceph fs subvolume ls a --group-name=_index
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2022-05-25T12:31:07.125+0530 7f78dac3e700 -1 WARNING: all dangerous and experimental features are enabled.
2022-05-25T12:31:07.133+0530 7f78dac3e700 -1 WARNING: all dangerous and experimental features are enabled.
[
    {
        "name": "clone" 
    }
]

# bin/ceph fs subvolume ls a --group-name=_deleting
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2022-05-25T12:31:27.209+0530 7f151262e700 -1 WARNING: all dangerous and experimental features are enabled.
2022-05-25T12:31:27.217+0530 7f151262e700 -1 WARNING: all dangerous and experimental features are enabled.
[]

This should throw proper error.


Related issues

Copied to CephFS - Backport #57057: quincy: mgr/volumes: Handle internal metadata directories under '/volumes' properly. Resolved
Copied to CephFS - Backport #57058: pacific: mgr/volumes: Handle internal metadata directories under '/volumes' properly. Resolved

History

#1 Updated by Kotresh Hiremath Ravishankar 6 months ago

  • Component(FS) mgr/volumes added

#2 Updated by Kotresh Hiremath Ravishankar 6 months ago

Note that we need to also ignore `_legacy`

#3 Updated by Venky Shankar 6 months ago

  • Category set to Correctness/Safety
  • Assignee set to Nikhilkumar Shelke
  • Target version set to v18.0.0
  • Backport set to quincy, pacific

#4 Updated by Nikhilkumar Shelke 5 months ago

  • Status changed from New to Fix Under Review

#5 Updated by Venky Shankar 5 months ago

  • Pull request ID set to 46927

#6 Updated by Venky Shankar 4 months ago

  • Status changed from Fix Under Review to Pending Backport

#7 Updated by Backport Bot 4 months ago

  • Copied to Backport #57057: quincy: mgr/volumes: Handle internal metadata directories under '/volumes' properly. added

#8 Updated by Backport Bot 4 months ago

  • Copied to Backport #57058: pacific: mgr/volumes: Handle internal metadata directories under '/volumes' properly. added

#9 Updated by Backport Bot 4 months ago

  • Tags set to backport_processed

#10 Updated by Venky Shankar 3 months ago

  • Assignee changed from Nikhilkumar Shelke to Kotresh Hiremath Ravishankar

Also available in: Atom PDF