Actions
Cleanup #55657
openrgw: remove potentially conficting definition of dout_subsys
% Done:
0%
Tags:
backport_processed
Backport:
quincy,pacific
Reviewed:
Affected Versions:
Pull request ID:
Description
dout_subsys should strictly be defined in .cc files. There was a
definition of dout_subsys in rgw_log.h, which is included in a variety
of .cc due to transitive includes. When a subsystem wants a
conflicting definition, a compiler warning was generated.
Updated by J. Eric Ivancich almost 2 years ago
An example issue....
/home2/ceph-work1/ceph/src/rgw/rgw_flight.cc:17: warning: "dout_subsys" redefined
17 | #define dout_subsys ceph_subsys_arrow_flight
|
In file included from /home2/ceph-work1/ceph/src/rgw/rgw_rados.h:23,
from /home2/ceph-work1/ceph/src/rgw/rgw_role.h:14,
from /home2/ceph-work1/ceph/src/rgw/rgw_sts.h:7,
from /home2/ceph-work1/ceph/src/rgw/rgw_rest_s3.h:30,
from /home2/ceph-work1/ceph/src/rgw/rgw_auth_s3.h:18,
from /home2/ceph-work1/ceph/src/rgw/rgw_auth_registry.h:15,
from /home2/ceph-work1/ceph/src/rgw/rgw_process.h:9,
from /home2/ceph-work1/ceph/src/rgw/rgw_frontend.h:13,
from /home2/ceph-work1/ceph/src/rgw/rgw_flight.h:12,
from /home2/ceph-work1/ceph/src/rgw/rgw_flight.cc:13:
/home2/ceph-work1/ceph/src/rgw/rgw_log.h:13: note: this is the location of the previous definition
13 | #define dout_subsys ceph_subsys_rgw
Updated by J. Eric Ivancich almost 2 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Backport Bot almost 2 years ago
- Copied to Backport #55677: pacific: rgw: remove potentially conficting definition of dout_subsys added
Updated by Backport Bot almost 2 years ago
- Copied to Backport #55678: quincy: rgw: remove potentially conficting definition of dout_subsys added
Actions