Project

General

Profile

Actions

Cleanup #5558

closed

rgw: modify certain radosgw-admin operations interface

Added by Yehuda Sadeh almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

We need to be more consistent with operations that read, write, list, and remove data:

region info                show region info
regions list list all regions set on this cluster
region set set region info
region default set default region
region-map show show region-map
region-map set set region-map
zone info show zone cluster params
zone set set zone cluster params
zone list list all zones set on this cluster
metadata get               get metadata info
metadata put put metadata info
metadata rm remove metadata info
metadata list list metadata info
mdlog list list metadata log
mdlog trim trim metadata log
bilog list list bucket index log
bilog trim trim bucket index log (use start-marker, end-marker)
datalog list list data log
datalog trim trim data log
opstate list list stateful operations entries (use client_id,
op_id, object)
opstate set set state on an entry (use client_id, op_id, object)
opstate renew renew state on an entry (use client_id, op_id, object)
opstate rm remove entry (use client_id, op_id, object)
replicalog get get replica metadata log entry
replicalog delete delete replica metadata log entry

Maybe make it so that get, show, and info all behave the same. But in any case try to be more consistent where needed.

Actions #1

Updated by Sage Weil almost 11 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Greg Farnum almost 11 years ago

Just renamed them all to "get" since the output corresponds to what you give "set", and I want to keep the command namespace clear for future additions. I'm going over these commands in a little more detail to check their input/output patterns as well and see if I can come up with a good way to indicate them on the help line.

Actions #3

Updated by Greg Farnum almost 11 years ago

  • Status changed from In Progress to Fix Under Review

Simple enough change. Passed my local make check.https://github.com/ceph/ceph/pull/420

Actions #4

Updated by Greg Farnum almost 11 years ago

  • Status changed from Fix Under Review to Resolved

Merged in commit:7f67848

Actions

Also available in: Atom PDF