Actions
Bug #5500
closedceph CLI should validate, reject bad daemon commands
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The CLI rewrite has the ability to validate commands before sending; it does this with mon and
osd commands, but not yet with admin-socket commands. We should close this gap; the error reporting
is awful:
admin_socket: exception: unpack requires a string argument of length 4
It's easy to extend the existing mechanisms to get a list of commands from the admin socket, validate
the passed command, and error out with useful messages in the CLI without submitting the bogus command.
Updated by Dan Mick almost 11 years ago
I should note that the admin socket already supports "get_command_descriptions" so this change is
all in the CLI.
Actions