Project

General

Profile

Actions

Bug #54581

closed

Virtual IP is not validated during the creation (service fails later)

Added by Redouane Kachach Elhichou about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Low
Category:
cephadm/nfs
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

virtual IP is not validated during the NFS service creation.

ceph nfs cluster create foo --ingress --virtual-ip 192.168.111/24 --port 2049
NFS Cluster Created Successfully
2022-03-16T12:08:20.299+0000 7f75a2cb8700 -1 log_channel(cephadm) log [ERR] : Failed to apply ingress.nfs.foo spec IngressSpec.from_json(yaml.safe_load('''service_type: ingress
service_id: nfs.foo
service_name: ingress.nfs.foo
placement:
  count: 2
spec:
  backend_service: nfs.foo
  frontend_port: 2049
  monitor_port: 9049
  virtual_ip: 192.168.111/24
''')): '192.168.111' does not appear to be an IPv4 or IPv6 address
Traceback (most recent call last):
  File "/usr/share/ceph/mgr/cephadm/serve.py", line 502, in _apply_all_services
    if self._apply_service(spec):
  File "/usr/share/ceph/mgr/cephadm/serve.py", line 768, in _apply_service
    daemon_spec = svc.prepare_create(daemon_spec)
  File "/usr/share/ceph/mgr/cephadm/services/ingress.py", line 32, in prepare_create
    return self.keepalived_prepare_create(daemon_spec)
  File "/usr/share/ceph/mgr/cephadm/services/ingress.py", line 163, in keepalived_prepare_create
    daemon_spec.final_config, daemon_spec.deps = self.keepalived_generate_config(daemon_spec)
  File "/usr/share/ceph/mgr/cephadm/services/ingress.py", line 202, in keepalived_generate_config
    if ifaces and ipaddress.ip_address(bare_ip) in ipaddress.ip_network(subnet):
  File "/lib64/python3.6/ipaddress.py", line 54, in ip_address


Related issues 1 (0 open1 closed)

Copied to Orchestrator - Backport #56069: quincy: Virtual IP is not validated during the creation (service fails later)ResolvedAdam KingActions
Actions #1

Updated by Redouane Kachach Elhichou about 2 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Redouane Kachach Elhichou about 2 years ago

  • Status changed from In Progress to Fix Under Review
  • Assignee set to Redouane Kachach Elhichou
  • Pull request ID set to 46364
Actions #3

Updated by Adam King almost 2 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to quincy
Actions #4

Updated by Backport Bot almost 2 years ago

  • Copied to Backport #56069: quincy: Virtual IP is not validated during the creation (service fails later) added
Actions #5

Updated by Redouane Kachach Elhichou almost 2 years ago

  • Status changed from Pending Backport to Closed
Actions #6

Updated by Adam King almost 2 years ago

  • Status changed from Closed to Resolved
Actions

Also available in: Atom PDF