Bug #54501: libcephfs: client needs to update the mtime and change attr when snaps are created and deleted - CephFS - Ceph

Actions

Copy link

Bug #54501

open

libcephfs: client needs to update the mtime and change attr when snaps are created and deleted

Added by Ramana Raja about 2 years ago. Updated about 1 year ago.

Status:

Pending Backport

Priority:

High

Assignee:

Venky Shankar

Category:

Correctness/Safety

Target version:

Ceph - v18.0.0

% Done:

Source:

Community (dev)

Tags:

backport_processed

Backport:

reef,quincy,pacific

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

libcephfs

Labels (FS):

Manila, NFS-cluster, snapshots

Pull request ID:

48382

Crash signature (v1):

Crash signature (v2):

Description

This issue was identified by Jeff here, https://bugzilla.redhat.com/show_bug.cgi?id=1975689#c21

The libcephfs client doesn't update mtime and change attribute when snaps are create or deleted. This results in NFS clients not being able to list CephFS snapshots within a CephFS NFS-Ganesha export correctly.
See explanation here, https://bugzilla.redhat.com/show_bug.cgi?id=1975689#c21

Related issues 5 (1 open — 4 closed)

Copied to CephFS - Backport #59038: quincy: libcephfs: client needs to update the mtime and change attr when snaps are created and deleted	Duplicate	Venky Shankar	Actions
Copied to CephFS - Backport #59039: pacific: libcephfs: client needs to update the mtime and change attr when snaps are created and deleted	Duplicate	Venky Shankar	Actions
Copied to CephFS - Backport #59040: pacific: libcephfs: client needs to update the mtime and change attr when snaps are created and deleted	Rejected	Venky Shankar	Actions
Copied to CephFS - Backport #59041: quincy: libcephfs: client needs to update the mtime and change attr when snaps are created and deleted	In Progress	Venky Shankar	Actions
Copied to CephFS - Backport #59412: reef: libcephfs: client needs to update the mtime and change attr when snaps are created and deleted	Resolved	Venky Shankar	Actions

Actions

Copy link

Updated by Xiubo Li about 2 years ago

Assignee set to Xiubo Li

Actions

Copy link

Updated by Xiubo Li about 2 years ago

Assignee deleted (~~Xiubo Li~~)

Actions

Copy link

Updated by Venky Shankar about 2 years ago

Category set to Correctness/Safety
Assignee set to Nikhilkumar Shelke
Target version set to v18.0.0
Source set to Community (dev)
Backport set to quincy, pacific

Nikhil,

Please take this (Xiubo is be a bit tied up with some other work).

Cheers,
Venky

Actions

Copy link

Updated by Venky Shankar over 1 year ago

Assignee changed from Nikhilkumar Shelke to Dhairya Parmar

Dhairya, PTAL.

Actions

Copy link

Updated by Venky Shankar over 1 year ago

Assignee changed from Dhairya Parmar to Venky Shankar

Actions

Copy link

Updated by Venky Shankar over 1 year ago

Assigning this to myself since I'm looking into related issues.

Actions

Copy link

Updated by Venky Shankar over 1 year ago

Ramana, nfs-ganesh is servicing stale readdir data by checking mtime/change_attr of .snap I presume or for its parent (i.e., "foo" dir for foo/.snap)?

Actions

Copy link

Updated by Venky Shankar over 1 year ago

Ramana, never mind. I see its for .snap directory rather that its parent. The thing is, attrs for .snap are initialized from its parent and never change (until the inode is trimmed and the snap directory is accessed again).

PR https://github.com/ceph/ceph/pull/48086 improves this behavior by updating attrs (including POSIX ACLs) for .snap directory when its parent directory attrs change. However, that is not enough to fix this issue.

Actions

Copy link