Bug #54463: mds: flush mdlog if locked and still has wanted caps not satisfied - CephFS - Ceph

Actions

Copy link

Bug #54463

closed

mds: flush mdlog if locked and still has wanted caps not satisfied

Added by Xiubo Li about 2 years ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Xiubo Li

Category:

Target version:

Ceph - v18.0.0

% Done:

Source:

Tags:

backport_processed

Backport:

quincy,pacific

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

MDS

Labels (FS):

Pull request ID:

45243

Crash signature (v1):

Crash signature (v2):

Description

In _do_cap_update() if one client is releasing the Fw caps the
relevant client range will be erased, and then new_max will be 0.
It will skip flushing the mdlog after it submitting a journal log,
which will keep holding the wrlock for the filelock.

So when a new client is trying to open the file for reading, since
the wrlock is locked for the filelock the file_eval() is possibly
couldn't changing the lock state and at the same time if the
filelock is in stable state, such as in EXECL, MIX. The mds may
skip flushing the mdlog in the open related code too.

We need to flush the mdlog if there still has any wanted caps
couldn't be satisfied and has any lock for the filelock after the
file_eval().

Related issues 2 (0 open — 2 closed)