Project

General

Profile

Actions

Bug #54198

closed

ceph orch status fails when xml formatting option is provided

Added by Redouane Kachach Elhichou about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Low
Category:
cephadm
Target version:
-
% Done:

0%

Source:
Tags:
low-hanging-fruit
Backport:
needed
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Steps to Reproduce:

1. try ceph orch status --detail --format xml


Actual results:
# ceph orch status --detail --format xml 
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1345, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 167, in handle_command
    return dispatch[cmd['prefix']].call(self, cmd, inbuf)
  File "/usr/share/ceph/mgr/mgr_module.py", line 386, in call
    kwargs = self._collect_args_by_argspec(cmd_dict)
  File "/usr/share/ceph/mgr/mgr_module.py", line 379, in _collect_args_by_argspec
    kwargs[k] = CephArgtype.cast_to(tp, v)
  File "/lib/python3.6/site-packages/ceph_argparse.py", line 243, in cast_to
    return tp(v)
  File "/lib64/python3.6/enum.py", line 293, in __call__
    return cls.__new__(cls, value)
  File "/lib64/python3.6/enum.py", line 535, in __new__
    return cls._missing_(value)
  File "/lib64/python3.6/enum.py", line 548, in _missing_
    raise ValueError("%r is not a valid %s" % (value, cls.__name__))
ValueError: 'xml' is not a valid Format


Expected results:
Tracebacks are not expected to be dumped to user for cli call

Actions #1

Updated by Redouane Kachach Elhichou about 2 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Redouane Kachach Elhichou about 2 years ago

  • Status changed from Fix Under Review to Resolved
Actions #4

Updated by Redouane Kachach Elhichou about 2 years ago

backported to pacific branch by PR: https://github.com/ceph/ceph/pull/45223

Actions #5

Updated by Redouane Kachach Elhichou about 2 years ago

  • Pull request ID set to 45023
Actions

Also available in: Atom PDF