Project

General

Profile

Bug #5409

mon: log command does not wait for commit

Added by Sage Weil almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
Monitor
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

the mon replies immediately, and may lose the msg if it restarts.

ubuntu@teuthology:/a/teuthology-2013-06-20_01:00:14-rados-next-testing-basic/40768$ cat orig.config.yaml 
kernel:
  kdb: true
  sha1: 2dd322b42d608a37f3e5beed57a8fbc673da6e32
machine_type: plana
nuke-on-error: true
overrides:
  admin_socket:
    branch: next
  ceph:
    conf:
      global:
        ms inject delay max: 1
        ms inject delay probability: 0.005
        ms inject delay type: osd
        ms inject socket failures: 2500
      mon:
        debug mon: 20
        debug ms: 1
        debug paxos: 20
    fs: xfs
    log-whitelist:
    - slow request
    sha1: c39b99cdecceaca77f66eafbcc38387406826406
  install:
    ceph:
      sha1: c39b99cdecceaca77f66eafbcc38387406826406
  s3tests:
    branch: next
  workunit:
    sha1: c39b99cdecceaca77f66eafbcc38387406826406
roles:
- - mon.a
  - mon.c
  - osd.0
  - osd.1
  - osd.2
- - mon.b
  - mds.a
  - osd.3
  - osd.4
  - osd.5
  - client.0
tasks:
- chef: null
- clock.check: null
- install: null
- ceph: null
- mon_thrash:
    revive_delay: 20
    thrash_delay: 1
- workunit:
    clients:
      client.0:
      - rados/test.sh

Associated revisions

Revision 4a038d6d (diff)
Added by Sage Weil almost 11 years ago

mon: make 'log ...' command wait for commit before reply

Previously we would just dump the command argument to our local log client
and reply immediately, which could lose the message if we then restarted.
Instead, commit directly and wait before replying.

Also, log as the actual client, not as the monitor processing the message.

Fixes: #5409
Signed-off-by: Sage Weil <>
Reviewed-by: Dan Mick <>

History

#1 Updated by Sage Weil almost 11 years ago

  • Status changed from 12 to Resolved

Also available in: Atom PDF