Project

General

Profile

Actions

Bug #53379

closed

mgr/prometheus: method timings are not present in the exported metrics

Added by Paul Cuzner over 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
prometheus module
Target version:
% Done:

0%

Source:
Tags:
backport_processed
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The method times are calculated, but when they are added to the metrics dict a typo prevents the per method timings from being exported

Current exported data

[ceph: root@cs8-prom /]# curl -s http://localhost:9283/metrics | grep ceph_prom                                                                                                                                       

# HELP ceph_prometheus_collect_duration_seconds_count The amount of metrics gathered for this exporter                                                                                                             
# TYPE ceph_prometheus_collect_duration_seconds_count counter                                                                                                                                                      
ceph_prometheus_collect_duration_seconds_count{method="get_health"} 1.0                                                                                                                                            
ceph_prometheus_collect_duration_seconds_count{method="get_pool_stats"} 1.0                                                                                                                                        
ceph_prometheus_collect_duration_seconds_count{method="get_df"} 1.0                                                                                                                                                
ceph_prometheus_collect_duration_seconds_count{method="get_fs"} 1.0                                                                                                                                                
ceph_prometheus_collect_duration_seconds_count{method="get_quorum_status"} 1.0                                                                                                                                     
ceph_prometheus_collect_duration_seconds_count{method="get_mgr_status"} 1.0                                                                                                                                        
ceph_prometheus_collect_duration_seconds_count{method="get_pg_status"} 1.0                                                                                                                                         
ceph_prometheus_collect_duration_seconds_count{method="get_osd_stats"} 1.0                                                                                                                                         
ceph_prometheus_collect_duration_seconds_count{method="get_metadata_and_osd_status"} 1.0                                                                                                                           
ceph_prometheus_collect_duration_seconds_count{method="get_num_objects"} 1.0                                                                                                                                       
ceph_prometheus_collect_duration_seconds_count{method="get_rbd_stats"} 1.0         

Desired/intended

[ceph: root@cs8-prom /]# curl -s http://localhost:9283/metrics | grep ceph_prom
# HELP ceph_prometheus_collect_duration_seconds_sum The sum of seconds took to collect all metrics of this exporter
# TYPE ceph_prometheus_collect_duration_seconds_sum counter
ceph_prometheus_collect_duration_seconds_sum{method="get_health"} 0.01711750030517578
ceph_prometheus_collect_duration_seconds_sum{method="get_pool_stats"} 0.004804134368896484
ceph_prometheus_collect_duration_seconds_sum{method="get_df"} 0.0078887939453125
ceph_prometheus_collect_duration_seconds_sum{method="get_fs"} 0.01891613006591797
ceph_prometheus_collect_duration_seconds_sum{method="get_quorum_status"} 0.019089698791503906
ceph_prometheus_collect_duration_seconds_sum{method="get_mgr_status"} 0.240189790725708
ceph_prometheus_collect_duration_seconds_sum{method="get_pg_status"} 0.009100675582885742
ceph_prometheus_collect_duration_seconds_sum{method="get_osd_stats"} 0.004758119583129883
ceph_prometheus_collect_duration_seconds_sum{method="get_metadata_and_osd_status"} 0.04722762107849121
ceph_prometheus_collect_duration_seconds_sum{method="get_num_objects"} 0.009373903274536133
ceph_prometheus_collect_duration_seconds_sum{method="get_rbd_stats"} 0.012253522872924805
# HELP ceph_prometheus_collect_duration_seconds_count The amount of metrics gathered for this exporter
# TYPE ceph_prometheus_collect_duration_seconds_count counter
ceph_prometheus_collect_duration_seconds_count{method="get_health"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_pool_stats"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_df"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_fs"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_quorum_status"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_mgr_status"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_pg_status"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_osd_stats"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_metadata_and_osd_status"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_num_objects"} 71.0
ceph_prometheus_collect_duration_seconds_count{method="get_rbd_stats"} 71.0


Related issues 1 (0 open1 closed)

Copied to mgr - Backport #53435: pacific: mgr/prometheus: method timings are not present in the exported metricsResolvedKonstantin ShalyginActions
Actions #1

Updated by Paul Cuzner over 2 years ago

  • Pull request ID set to 44082
Actions #2

Updated by Paul Cuzner over 2 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Konstantin Shalygin over 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Backport Bot over 2 years ago

  • Copied to Backport #53435: pacific: mgr/prometheus: method timings are not present in the exported metrics added
Actions #5

Updated by Backport Bot over 1 year ago

  • Tags set to backport_processed
Actions #6

Updated by Konstantin Shalygin over 1 year ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF