Project

General

Profile

Feature #53229

mgr/prometheus: Make prometheus standby behaviour configurable

Added by Roland Sommer over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
prometheus module
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
pacific
Reviewed:
Affected Versions:
Pull request ID:

Description

The dashboard module provides configuration options to configure the standby behaviour for better integration with reverse proxys or loadbalancers. Adding this to the prometheus module simplifys a similiar setup for the prometheus endpoint.

The pull request has already been approved and is ready to merge, target release (from our side) would be pacific. Tracker issue opened as requested.

PR: https://github.com/ceph/ceph/pull/43464


Related issues

Related to Dashboard - Bug #53241: mgr/prometheus: fix mgr/prometheus default standby behavior Fix Under Review
Copied to mgr - Backport #53234: pacific: mgr/prometheus: Make prometheus standby behaviour configurable Resolved

History

#1 Updated by Ernesto Puerta over 2 years ago

  • Project changed from RADOS to mgr
  • Category set to prometheus module
  • Status changed from New to Pending Backport
  • Target version set to v17.0.0
  • Source set to Community (dev)
  • Pull request ID set to 43464

#2 Updated by Backport Bot over 2 years ago

  • Copied to Backport #53234: pacific: mgr/prometheus: Make prometheus standby behaviour configurable added

#3 Updated by Konstantin Shalygin over 2 years ago

  • Assignee set to Roland Sommer

#4 Updated by Patrick Seidensal over 2 years ago

  • Related to Bug #53241: mgr/prometheus: fix mgr/prometheus default standby behavior added

#5 Updated by Roland Sommer over 2 years ago

I'm not quite sure what the state of this is: as of https://github.com/ceph/ceph/pull/43464#discussion_r731188564, I removed the default value as requested. The main PR has been merged to master, but the backport to pacific is pending because

module.get_module_option('standby_behaviour')

does not return the default value configured in the Option block. As this seems to be tackled by https://github.com/ceph/ceph/pull/43904 and https://github.com/ceph/ceph/pull/44132, is there anything to be done on my side as of now?

#6 Updated by Ernesto Puerta about 2 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF