Cleanup #52754: windows warnings - RADOS - Ceph

Actions

Copy link

Cleanup #52754

open

Cleanup #52752: fix warnings

windows warnings

Added by Deepika Upadhyay over 2 years ago. Updated over 1 year ago.

Status:

New

Priority:

Low

Assignee:

Category:

Target version:

% Done:

Tags:

Backport:

Reviewed:

Affected Versions:

Component(RADOS):

Pull request ID:

Description

../src/client/Client.cc: In member function 'int Client::_setattr(InodeRef&, _stat64*, int, const UserPerm&)':
../src/client/Client.cc:7686:49: warning: comparison of integer expressions of different signedness: 'short int' and 'uid_t' {aka 'unsigned int'} [-Wsign-compare]
 7686 |   if ((mask & CEPH_SETATTR_UID) && attr->st_uid == static_cast<uid_t>(-1)) {
      |                                    ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
../src/client/Client.cc:7689:49: warning: comparison of integer expressions of different signedness: 'short int' and 'uid_t' {aka 'unsigned int'} [-Wsign-compare]
 7689 |   if ((mask & CEPH_SETATTR_GID) && attr->st_gid == static_cast<uid_t>(-1)) {
      |                                    ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~

find more at: https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=windows,DIST=windows,MACHINE_SIZE=gigantic/57699//consoleFull

Actions

Copy link

Updated by Deepika Upadhyay over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Laura Flores over 2 years ago

Deepika, the link is 404 now. Is there a way that we could preserve the Jenkins output and provide a different link?

Actions

Copy link

Updated by Deepika Upadhyay over 2 years ago

Priority changed from Normal to Low

@Laura, they appear in windows shaman builds, anyone can take a look at the latest windows builds available here https://shaman.ceph.com/builds/ although, I would treat this as low priority right now :)

Actions

Copy link