Actions
Bug #52619
openceph-volume lvm activate command doesn't parse args properly
% Done:
0%
Source:
Tags:
Backport:
pacific,octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Description
ceph-volume lvm activate requires both osd_id and osd_fsid.
It means if I only pass 1 argument, it should nicely fail and not throw an error like following:
[root@local /]# CEPH_VOLUME_DEBUG=0 ceph-volume lvm activate --bluestore 34470d07-2341-43fa-acb3-8bdc0903bd36
Traceback (most recent call last):
File "/usr/sbin/ceph-volume", line 11, in <module>
load_entry_point('ceph-volume==1.0.0', 'console_scripts', 'ceph-volume')()
File "/usr/lib/python3.6/site-packages/ceph_volume/main.py", line 41, in __init__
self.main(self.argv)
File "/usr/lib/python3.6/site-packages/ceph_volume/decorators.py", line 59, in newfunc
return f(*a, **kw)
File "/usr/lib/python3.6/site-packages/ceph_volume/main.py", line 153, in main
terminal.dispatch(self.mapper, subcommand_args)
File "/usr/lib/python3.6/site-packages/ceph_volume/terminal.py", line 194, in dispatch
instance.main()
File "/usr/lib/python3.6/site-packages/ceph_volume/devices/lvm/main.py", line 46, in main
terminal.dispatch(self.mapper, self.argv)
File "/usr/lib/python3.6/site-packages/ceph_volume/terminal.py", line 194, in dispatch
instance.main()
File "/usr/lib/python3.6/site-packages/ceph_volume/devices/lvm/activate.py", line 378, in main
self.activate(args)
File "/usr/lib/python3.6/site-packages/ceph_volume/decorators.py", line 16, in is_root
return func(*a, **kw)
File "/usr/lib/python3.6/site-packages/ceph_volume/devices/lvm/activate.py", line 270, in activate
'osd_fsid too'.format(osd_id))
RuntimeError: could not activate osd.34470d07-2341-43fa-acb3-8bdc0903bd36, please provide the osd_fsid too
Updated by Guillaume Abrioux over 2 years ago
- Backport set to pacific,octopus
- Pull request ID set to 43171
Actions