Project

General

Profile

Bug #52282

Feature #47497: mgr/dashboard: add visual regression testing

mgr/dashboard: False positives in visual regression tests of dashboard component

Added by Aaryan Porwal over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Description of problem

Currently, we're only ignoring the chart-container CSS selector, which is insufficient as we have other dynamic content on the dashboard component as well.
A lot of PRs like this have reported false positives due to changing text on the landing page or the 6px top padding on the charts.

I propose we use a different CSS selector, probably of parent class like `card-text`, which covers all the dynamic regions to mitigate these false positives.


Related issues

Copied to Dashboard - Backport #52292: pacific: mgr/dashboard: False positives in visual regression tests of dashboard component Resolved

History

#1 Updated by Aaryan Porwal over 2 years ago

  • Pull request ID set to 42786

#2 Updated by Alfonso Martínez over 2 years ago

  • Status changed from In Progress to Fix Under Review
  • Backport set to pacific

#3 Updated by Aaryan Porwal over 2 years ago

  • Parent task set to #47497

#4 Updated by Alfonso Martínez over 2 years ago

  • Status changed from Fix Under Review to Pending Backport

#5 Updated by Backport Bot over 2 years ago

  • Copied to Backport #52292: pacific: mgr/dashboard: False positives in visual regression tests of dashboard component added

#6 Updated by Ernesto Puerta over 2 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF