Project

General

Profile

Bug #51956

mds: switch to use ceph_assert() instead of assert()

Added by Xiubo Li over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If the -DNDEBUG was specified when build the code, the assert() will do nothing.

I hit one odd issue that when I testing the "mds_kill_{import,export}_at", it will only work for the local test, not work for the teuthology test. Checked it found that when the '-DNODEBUG' is specified when building ceph code, the "assert()" will do nothing.

We need to switch to use "ceph_assert()" instead.

History

#1 Updated by Xiubo Li over 2 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 42541

#2 Updated by Patrick Donnelly over 2 years ago

  • Target version set to v17.0.0
  • Source set to Development
  • ceph-qa-suite deleted (fs)
  • Component(FS) MDS added

#3 Updated by Xiubo Li over 2 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF