Actions
Bug #51902
closedcephadm adopt fails on clean_cgroup
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
Regression:
Yes
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Until recently, the cephadm adopt command was working perfectly.
Now this ends up with a stack trace
fatal: [mon0]: FAILED! => changed=true cmd: - cephadm - --image - quay.ceph.io/ceph-ci/daemon:latest-master - adopt - --cluster - ceph - --name - mon.mon0 - --style - legacy - --skip-pull delta: '0:00:03.046505' end: '2021-07-28 06:09:26.258595' rc: 1 start: '2021-07-28 06:09:23.212090' stderr: |- Stopping old systemd unit ceph-mon@mon0... Disabling old systemd unit ceph-mon@mon0... Moving data... Chowning content... Moving logs... Creating new units... Traceback (most recent call last): File "/sbin/cephadm", line 8301, in <module> main() File "/sbin/cephadm", line 8289, in main r = ctx.func(ctx) File "/sbin/cephadm", line 1764, in _default_image return func(ctx) File "/sbin/cephadm", line 5091, in command_adopt command_adopt_ceph(ctx, daemon_type, daemon_id, fsid) File "/sbin/cephadm", line 5299, in command_adopt_ceph osd_fsid=osd_fsid) File "/sbin/cephadm", line 2884, in deploy_daemon_units clean_cgroup(ctx, unit_name) File "/sbin/cephadm", line 2724, in clean_cgroup if not ctx.fsid: File "/sbin/cephadm", line 155, in __getattr__ return super().__getattribute__(name) AttributeError: 'CephadmContext' object has no attribute 'fsid' stderr_lines: <omitted> stdout: '' stdout_lines: <omitted>
Note that the fsid is set in the /etc/ceph/ceph.conf and the config has been assimilated.
# ceph --version ceph version 17.0.0-6387-gf0027c05 (f0027c05c6d9de386fe963c04791f8b64dcaf290) quincy (dev)
Looks like a regression introduced by https://github.com/ceph/ceph/commit/1fee255ee4ceab99684c34e3e64532b2eb555a9e
Updated by Dimitri Savineau over 2 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 42538
Updated by Kefu Chai over 2 years ago
- Status changed from Fix Under Review to Resolved
Actions