Project

General

Profile

Actions

Bug #51811

closed

ceph-volume lvm migrate without args raises an exception

Added by Dimitri Savineau almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Target version:
% Done:

0%

Source:
Tags:
Backport:
pacific,octopus
Regression:
No
Severity:
3 - minor
Reviewed:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

# ceph-volume lvm migrate

Moves BlueFS data from source volume(s) to the target one, source
volumes (except the main (i.e. data or block) one) are removed on
success. LVM volumes are permitted for Target only, both already
attached or new logical one. In the latter case it is attached to OSD
replacing one of the source devices. Following replacement rules apply
(in the order of precedence, stop on the first match):
* if source list has DB volume - target device replaces it.
* if source list has WAL volume - target device replace it.
* if source list has slow volume only - operation is not permitted,
  requires explicit allocation via new-db/new-wal command.

Example calls for supported scenarios:

  Moves BlueFS data from main device to LV already attached as DB:

    ceph-volume lvm migrate --osd-id 1 --osd-fsid <uuid> --from data --target vgname/db

  Moves BlueFS data from shared main device to LV which will be attached
   as a new DB:

    ceph-volume lvm migrate --osd-id 1 --osd-fsid <uuid> --from data --target vgname/new_db

  Moves BlueFS data from DB device to new LV, DB is replaced:

    ceph-volume lvm migrate --osd-id 1 --osd-fsid <uuid> --from db --target vgname/new_db

  Moves BlueFS data from main and DB devices to new LV, DB is replaced:

    ceph-volume lvm migrate --osd-id 1 --osd-fsid <uuid> --from data db --target vgname/new_db

  Moves BlueFS data from main, DB and WAL devices to new LV, WAL is
   removed and DB is replaced:

    ceph-volume lvm migrate --osd-id 1 --osd-fsid <uuid> --from data db wal --target vgname/new_db

  Moves BlueFS data from main, DB and WAL devices to main device, WAL
   and DB are removed:

    ceph-volume lvm migrate --osd-id 1 --osd-fsid <uuid> --from db wal --target vgname/data

-->  AttributeError: 'Migrate' object has no attribute 'args'

From the ceph-volume logs

[2021-07-22 17:08:03,689][ceph_volume.main][INFO  ] Running command: ceph-volume  lvm migrate
[2021-07-22 17:08:03,691][ceph_volume][ERROR ] exception caught by decorator
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/ceph_volume/decorators.py", line 59, in newfunc
    return f(*a, **kw)
  File "/usr/lib/python3.6/site-packages/ceph_volume/main.py", line 151, in main
    terminal.dispatch(self.mapper, subcommand_args)
  File "/usr/lib/python3.6/site-packages/ceph_volume/terminal.py", line 194, in dispatch
    instance.main()
  File "/usr/lib/python3.6/site-packages/ceph_volume/devices/lvm/main.py", line 46, in main
    terminal.dispatch(self.mapper, self.argv)
  File "/usr/lib/python3.6/site-packages/ceph_volume/terminal.py", line 194, in dispatch
    instance.main()
  File "/usr/lib/python3.6/site-packages/ceph_volume/devices/lvm/migrate.py", line 520, in main
    self.migrate_osd()
  File "/usr/lib/python3.6/site-packages/ceph_volume/decorators.py", line 16, in is_root
    return func(*a, **kw)
  File "/usr/lib/python3.6/site-packages/ceph_volume/devices/lvm/migrate.py", line 403, in migrate_osd
    if self.args.osd_id:
AttributeError: 'Migrate' object has no attribute 'args'

I've set 15.2.14 and 16.2.6 as affected versions even if those versions don't exist because the backports have been merged into the stable branches but not part of a stable releases.


Related issues 2 (0 open2 closed)

Copied to ceph-volume - Backport #52554: pacific: ceph-volume lvm migrate without args raises an exceptionResolvedGuillaume AbriouxActions
Copied to ceph-volume - Backport #52555: octopus: ceph-volume lvm migrate without args raises an exceptionResolvedGuillaume AbriouxActions
Actions #1

Updated by Dimitri Savineau over 2 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Dimitri Savineau
  • Backport set to pacific,octopus
  • Pull request ID set to 43042
Actions #2

Updated by Dimitri Savineau over 2 years ago

  • Target version set to v17.0.0
Actions #3

Updated by Guillaume Abrioux over 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Guillaume Abrioux over 2 years ago

  • Copied to Backport #52554: pacific: ceph-volume lvm migrate without args raises an exception added
Actions #5

Updated by Guillaume Abrioux over 2 years ago

  • Copied to Backport #52555: octopus: ceph-volume lvm migrate without args raises an exception added
Actions #6

Updated by Guillaume Abrioux over 2 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF