Project

General

Profile

Actions
Copy link

Bug #51799

closed

osd: snaptrim logs to derr at every tick

Added by Arthur Outhenin-Chalandre over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Snapshots
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
42460
Crash signature (v1):
Crash signature (v2):

Description

Hi,

We reduced `osd_snap_trim_sleep` to 0.1 to speed up snap trim process but now the OSD spam the log on every tick with this line:
```
2021-07-22T11:23:26.617+0200 7fc201548700 -1 osd.59 pg_epoch: 20477 pg[3.abf( v 20477'622313 (20477'618079,20477'622313] local-lis/les=18535/18536 n=159563 ec=693/660 lis/c=18535/18535 les/c/f=18536/18537/0 sis=18535) [59,61,123] r=0 lpr=18535 luod=20477'622311 crt=20477'622313 lcod 20477'622309 mlcod 20477'622309 active+clean+snaptrim trimq=189 ps=147] removing snap head
```

This is because of https://github.com/ceph/ceph/blob/3117a6c3dd51f61e7b48dfa2d4fac9d86d5c021f/src/osd/PrimaryLogPG.cc#L4812 which logs this line on derr instead of logging it with dout. I think that logging with dout(10) would make sense in this case because I don't think that's a information valuable enough for dout(5).

Related issues 2 (0 open — 2 closed)

Copied to RADOS - Backport #51840: pacific: osd: snaptrim logs to derr at every tickResolvedActions
Copied to RADOS - Backport #51841: octopus: osd: snaptrim logs to derr at every tickResolvedActions
Actions
Copy link
 #1

Updated by Neha Ojha over 2 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 42460
Actions
Copy link
 #2

Updated by Kefu Chai over 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #3

Updated by Backport Bot over 2 years ago

  • Copied to Backport #51840: pacific: osd: snaptrim logs to derr at every tick added
Actions
Copy link
 #4

Updated by Backport Bot over 2 years ago

  • Copied to Backport #51841: octopus: osd: snaptrim logs to derr at every tick added
Actions
Copy link
 #5

Updated by Loïc Dachary over 2 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF