Bug #51677
default value of follow_olh in get_obj_state() differs between sal::Object and RadosObject
% Done:
100%
Source:
Tags:
zipper
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Description
rgw_sal.h:virtual int get_obj_state(const DoutPrefixProvider* dpp, RGWObjectCtx* rctx, RGWObjState **state, optional_yield y, bool follow_olh = false) = 0; rgw_sal_rados.h:virtual int get_obj_state(const DoutPrefixProvider* dpp, RGWObjectCtx* rctx, RGWObjState **state, optional_yield y, bool follow_olh = true) override;
i don't recommend using defaults in virtual functions, because the compiler doesn't help catch issues like this
Related issues
History
#1 Updated by Daniel Gryniewicz over 2 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 42455
#2 Updated by Daniel Gryniewicz over 2 years ago
- Backport set to pacific
#3 Updated by Casey Bodley over 2 years ago
- Status changed from Fix Under Review to Pending Backport
#4 Updated by Backport Bot over 2 years ago
- Copied to Backport #51810: pacific: default value of follow_olh in get_obj_state() differs between sal::Object and RadosObject added
#5 Updated by Backport Bot over 1 year ago
- Tags changed from zipper to zipper backport_processed
#6 Updated by Konstantin Shalygin over 1 year ago
- Status changed from Pending Backport to Resolved
- % Done changed from 0 to 100
- Tags changed from zipper backport_processed to zipper