Project

General

Profile

Bug #51677

default value of follow_olh in get_obj_state() differs between sal::Object and RadosObject

Added by Casey Bodley 2 months ago. Updated 2 months ago.

Status:
Pending Backport
Priority:
Normal
Target version:
-
% Done:

0%

Source:
Tags:
zipper
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

rgw_sal.h:virtual int get_obj_state(const DoutPrefixProvider* dpp, RGWObjectCtx* rctx, RGWObjState **state, optional_yield y, bool follow_olh = false) = 0;
rgw_sal_rados.h:virtual int get_obj_state(const DoutPrefixProvider* dpp, RGWObjectCtx* rctx, RGWObjState **state, optional_yield y, bool follow_olh = true) override;

i don't recommend using defaults in virtual functions, because the compiler doesn't help catch issues like this

Related issues

Copied to rgw - Backport #51810: pacific: default value of follow_olh in get_obj_state() differs between sal::Object and RadosObject New

History

#1 Updated by Daniel Gryniewicz 2 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 42455

#2 Updated by Daniel Gryniewicz 2 months ago

  • Backport set to pacific

#3 Updated by Casey Bodley 2 months ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Backport Bot 2 months ago

  • Copied to Backport #51810: pacific: default value of follow_olh in get_obj_state() differs between sal::Object and RadosObject added

Also available in: Atom PDF