Project

General

Profile

Actions

Bug #51667

closed

cephadm: host add existing host should be noop

Added by Dan van der Ster almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I ran `host add` from an _admin/mon host and it reset the addr to 127.0.1.1 and removed the labels.
I think this should rather be a NOOP, or error and require --force, if the host exists already? And it shouldn't remove labels.

[root@cephdata21a-6615b2ea9a ~]# cephadm shell -- ceph orch host ls
Inferring fsid f693d486-e3df-11eb-b83e-0c42a1ad63b6
Inferring config /var/lib/ceph/f693d486-e3df-11eb-b83e-0c42a1ad63b6/mon.cephdata21a-6615b2ea9a.cern.ch/config
Using recent ceph image registry.cern.ch/ceph/ceph@sha256:f11f0f368df32c7357447cca51db19bce95d2b66757b5e5c6ef037a1f0ab3245
HOST                            ADDR         LABELS      STATUS
cephdata21a-6615b2ea9a.cern.ch  10.116.5.78  _admin mon
cephdata21a-70eb18a304.cern.ch  10.116.5.76  _admin mon
cephdata21a-82d42977b5.cern.ch  10.116.5.83  _admin mon

[root@cephdata21a-6615b2ea9a ~]# cephadm shell -- ceph orch host add cephdata21a-6615b2ea9a.cern.ch
Inferring fsid f693d486-e3df-11eb-b83e-0c42a1ad63b6
Inferring config /var/lib/ceph/f693d486-e3df-11eb-b83e-0c42a1ad63b6/mon.cephdata21a-6615b2ea9a.cern.ch/config
Using recent ceph image registry.cern.ch/ceph/ceph@sha256:f11f0f368df32c7357447cca51db19bce95d2b66757b5e5c6ef037a1f0ab3245
Added host 'cephdata21a-6615b2ea9a.cern.ch' with addr '127.0.1.1'

[root@cephdata21a-6615b2ea9a ~]# cephadm shell -- ceph orch host ls
Inferring fsid f693d486-e3df-11eb-b83e-0c42a1ad63b6
Inferring config /var/lib/ceph/f693d486-e3df-11eb-b83e-0c42a1ad63b6/mon.cephdata21a-6615b2ea9a.cern.ch/config
Using recent ceph image registry.cern.ch/ceph/ceph@sha256:f11f0f368df32c7357447cca51db19bce95d2b66757b5e5c6ef037a1f0ab3245
HOST                            ADDR         LABELS      STATUS
cephdata21a-6615b2ea9a.cern.ch  127.0.1.1
cephdata21a-70eb18a304.cern.ch  10.116.5.76  _admin mon
cephdata21a-82d42977b5.cern.ch  10.116.5.83  _admin mon

[root@cephdata21a-6615b2ea9a ~]# cephadm shell -- ceph orch host add cephdata21a-6615b2ea9a.cern.ch 10.116.5.78
Inferring fsid f693d486-e3df-11eb-b83e-0c42a1ad63b6
Inferring config /var/lib/ceph/f693d486-e3df-11eb-b83e-0c42a1ad63b6/mon.cephdata21a-6615b2ea9a.cern.ch/config
Using recent ceph image registry.cern.ch/ceph/ceph@sha256:f11f0f368df32c7357447cca51db19bce95d2b66757b5e5c6ef037a1f0ab3245
2021-07-14T09:31:51.046+0000 7fa4664a5700 -1 auth: unable to find a keyring on /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,: (2) No such file or directory
2021-07-14T09:31:51.046+0000 7fa4664a5700 -1 AuthRegistry(0x7fa46005f4b0) no keyring found at /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,, disabling cephx
2021-07-14T09:31:51.047+0000 7fa4664a5700 -1 auth: unable to find a keyring on /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,: (2) No such file or directory
2021-07-14T09:31:51.047+0000 7fa4664a5700 -1 AuthRegistry(0x7fa4664a3ea0) no keyring found at /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,, disabling cephx
2021-07-14T09:31:51.048+0000 7fa4654a3700 -1 monclient(hunting): handle_auth_bad_method server allowed_methods [2] but i only support [1]
2021-07-14T09:31:51.048+0000 7fa464ca2700 -1 monclient(hunting): handle_auth_bad_method server allowed_methods [2] but i only support [1]
2021-07-14T09:31:51.048+0000 7fa4664a5700 -1 monclient: authenticate NOTE: no keyring found; disabled cephx authentication
[errno 13] RADOS permission denied (error connecting to the cluster)
Actions #1

Updated by Sebastian Wagner over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Daniel Pivonka
Actions #2

Updated by Daniel Pivonka over 2 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 42772
Actions #3

Updated by Daniel Pivonka over 2 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to pacific
Actions #4

Updated by Sebastian Wagner over 2 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF