Bug #51634: Validate allowed characters for rgw reams - Orchestrator - Ceph

Actions

Copy link

Bug #51634

closed

Validate allowed characters for rgw reams

Added by Sebastian Wagner almost 3 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Redouane Kachach Elhichou

Category:

cephadm/rgw

Target version:

% Done:

Source:

Tags:

low-hanging-fruit

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

# ceph orch ls --service-type rgw --format yaml

service_type: rgw
service_id: rgw.all
service_name: rgw.rgw.all
placement:
  label: rgw
spec:
  rgw_frontend_port: 443
  rgw_realm: /etc/ssl/certs/server.pem
  ssl: true
status:
  created: '2021-07-12T12:45:04.261390Z'
  running: 0
  size: 1
events:
- 2021-07-12T06:26:04.982069Z service:rgw.rgw.all [INFO] "service was created"

Actions

Copy link

Updated by Sebastian Wagner almost 3 years ago

Category set to cephadm/rgw

Actions

Copy link

Updated by Redouane Kachach Elhichou about 2 years ago

Assignee set to Redouane Kachach Elhichou

Actions

Copy link

Updated by Redouane Kachach Elhichou about 2 years ago

I did some investigation on this issue and the current status is:

From RGW side there's no restriction on the realm names
RGW realms can be created with any characters (including / and ")
Services seem to be created correctly (I didn't test the RGW functionality itself)
mgr failover seem to work correctly when inserting a " character in the realm name (from/to json converstions works correctly)
```
* dumping the RGW spec from cephadm works without issues: ceph config-key dump mgr/cephadm/spec.<rgw-spec-name>
```

My conclusion is by now no changes are needed at the cephadm module.

Actions

Copy link

Updated by Redouane Kachach Elhichou about 2 years ago

Status changed from New to Closed

As result of my investigation it seems that cephadm doesn't need to perform any validation on realm names by now since RGW is very permissive on this aspect and the user can use any characters on the name.

Actions

Copy link