Bug #51630: mgr/snap_schedule: don't throw traceback on non-existent fs - CephFS - Ceph

Actions

Copy link

Bug #51630

open

mgr/snap_schedule: don't throw traceback on non-existent fs

Added by Varsha Rao almost 3 years ago. Updated over 2 years ago.

Status:

Fix Under Review

Priority:

Normal

Assignee:

Category:

Target version:

Ceph - v17.0.0

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

mgr/snap_schedule

Labels (FS):

snapshots, task(easy)

Pull request ID:

43386

Crash signature (v1):

Crash signature (v2):

Description

Instead return error message and log the traceback

[root@localhost build]# ./bin/ceph fs snap-schedule add --path=/cephnfs-path 1h --fs=cephfs
Error EINVAL: Traceback (most recent call last):
  File "/home/varsha/ceph/src/pybind/mgr/mgr_module.py", line 1563, in _handle_command
    return CLICommand.COMMANDS[cmd['prefix']].call(self, cmd, inbuf)
  File "/home/varsha/ceph/src/pybind/mgr/mgr_module.py", line 412, in call
    return self.func(mgr, **kwargs)
  File "/home/varsha/ceph/src/pybind/mgr/snap_schedule/module.py", line 128, in snap_schedule_add
    self.client.store_snap_schedule(use_fs,
  File "/home/varsha/ceph/src/pybind/mgr/snap_schedule/fs/schedule_client.py", line 60, in f
    ret = func(self, fs, schedule_or_path, *args)
  File "/home/varsha/ceph/src/pybind/mgr/snap_schedule/fs/schedule_client.py", line 290, in store_snap_schedule
    db = self.get_schedule_db(fs)
  File "/home/varsha/ceph/src/pybind/mgr/snap_schedule/fs/schedule_client.py", line 132, in get_schedule_db
    assert poolid, f'fs "{fs}" not found'
AssertionError: fs "cephfs" not found