Bug #51619
Bluestore repair might erroneously remove SharedBlob entries.
0%
Description
in
void BlueStore::_fsck_check_pool_statfs(
the following lines
if (repairer) {
repairer->remove_key(db, PREFIX_SHARED_BLOB, key);
}
should be
if (repairer) {
repairer->remove_key(db, PREFIX_STAT, key);
}
The bug triggers when stray Pool statfs records are found and exposed to removal, e.g.
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2c90
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2caf
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2cce
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2ced
Then Shared blobs with matching ids would be removed instead.
Related issues
History
#1 Updated by Igor Fedotov over 2 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 42267
#2 Updated by Kefu Chai over 2 years ago
- Description updated (diff)
#3 Updated by Kefu Chai over 2 years ago
- Status changed from Fix Under Review to Pending Backport
#4 Updated by Backport Bot over 2 years ago
- Copied to Backport #51648: nautilus: Bluestore repair might erroneously remove SharedBlob entries. added
#5 Updated by Backport Bot over 2 years ago
- Copied to Backport #51649: pacific: Bluestore repair might erroneously remove SharedBlob entries. added
#6 Updated by Backport Bot over 2 years ago
- Copied to Backport #51650: octopus: Bluestore repair might erroneously remove SharedBlob entries. added
#7 Updated by Igor Fedotov over 2 years ago
- Assignee set to Igor Fedotov
#8 Updated by Igor Fedotov over 2 years ago
- Status changed from Pending Backport to Resolved