Project

General

Profile

Bug #51619

Bluestore repair might erroneously remove SharedBlob entries.

Added by Igor Fedotov 3 months ago. Updated 2 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
missing SharedBlob
Backport:
pacific, octopus, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

in
void BlueStore::_fsck_check_pool_statfs(

the following lines

    if (repairer) {
      repairer->remove_key(db, PREFIX_SHARED_BLOB, key);
    }

should be

    if (repairer) {
      repairer->remove_key(db, PREFIX_STAT, key);
    }

The bug triggers when stray Pool statfs records are found and exposed to removal, e.g.
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2c90
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2caf
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2cce
2021-07-08T12:12:12.128+0200 7efde5532100 20 bluestore(/var/lib/ceph/osd/ceph-42) fsck inf: found empty stray Pool StatFS record for pool id 0x2ced

Then Shared blobs with matching ids would be removed instead.


Related issues

Copied to bluestore - Backport #51648: nautilus: Bluestore repair might erroneously remove SharedBlob entries. New
Copied to bluestore - Backport #51649: pacific: Bluestore repair might erroneously remove SharedBlob entries. Resolved
Copied to bluestore - Backport #51650: octopus: Bluestore repair might erroneously remove SharedBlob entries. Resolved

History

#1 Updated by Igor Fedotov 3 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 42267

#2 Updated by Kefu Chai 2 months ago

  • Description updated (diff)

#3 Updated by Kefu Chai 2 months ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Backport Bot 2 months ago

  • Copied to Backport #51648: nautilus: Bluestore repair might erroneously remove SharedBlob entries. added

#5 Updated by Backport Bot 2 months ago

  • Copied to Backport #51649: pacific: Bluestore repair might erroneously remove SharedBlob entries. added

#6 Updated by Backport Bot 2 months ago

  • Copied to Backport #51650: octopus: Bluestore repair might erroneously remove SharedBlob entries. added

#7 Updated by Igor Fedotov 2 months ago

  • Assignee set to Igor Fedotov

Also available in: Atom PDF