Bug #51520
notifications: send only CompleteMultipartUpload notification
% Done:
0%
Source:
Q/A
Tags:
notifications backport_processed
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Description
existing behavior
- first notifications is: s3:ObjectCreated:Post
- every part uploaded will send: s3:ObjectCreated:Put
- when upload is complete, you will get: s3:ObjectCreated:CompleteMultipartUpload
requirements
- the POST notification sent at the beginning of the multipart upload should not be sent
- the intermediate PUT notifications sent during the multipart upload should not be sent either
testing
- for manual testing see: https://gist.github.com/yuvalif/f8a652d8afd4f48478bdbc1ec5a9187f
- automated tests should be added as well: https://github.com/ceph/ceph/blob/master/src/test/rgw/bucket_notification/test_bn.py
- note that some tests may need to be modified, if they describe the existing behavior
- please also add a tests for the regular POST event
code
- remove notifications from here: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_op.cc#L5946
note that we should make sure we test the regular POST object upload (see: https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPOST.html) where we do expect a notifications to be sent
- PUT: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_op.cc#L3719
here we have to distinguish between a regular PUT and the one which is part of the multipart upload
note that we should make sure we test the regular POST object upload (see: https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPOST.html) where we do expect a notifications to be sent
here we have to distinguish between a regular PUT and the one which is part of the multipart upload
documentation:
add a note here: https://github.com/ceph/ceph/blob/master/doc/radosgw/s3-notification-compatibility.rst#event-types
explaining the the behavior in case of multipart upload.¶
release notes
since this is a change in product behavior, there should be a note added to: https://github.com/ceph/ceph/blob/master/PendingReleaseNotes¶
Related issues
History
#1 Updated by Yuval Lifshitz over 2 years ago
existing behavior¶
- first notifications is: s3:ObjectCreated:Post
- every part uploaded will send: s3:ObjectCreated:Put
- when upload is complete, you will get: s3:ObjectCreated:CompleteMultipartUpload
requirements¶
- the POST notification sent at the beginning of the multipart upload should not be sent
- the intermediate PUT notifications sent during the multipart upload should not be sent either
testing¶
- for manual testing see: https://gist.github.com/yuvalif/f8a652d8afd4f48478bdbc1ec5a9187f
- automated tests should be added as well: https://github.com/ceph/ceph/blob/master/src/test/rgw/bucket_notification/test_bn.py
- note that some tests may need to be modified, if they describe the existing behavior
- please also add a tests for the regular POST event
code¶
- remove notifications from here: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_op.cc#L5946
- note that we should make sure we test the regular POST object upload (see: https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPOST.html) where we do expect a notifications to be sent
- PUT: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_op.cc#L3719
here we have to distinguish between a regular PUT and the one which is part of the multipart upload
documentation:¶
add a note here: https://github.com/ceph/ceph/blob/master/doc/radosgw/s3-notification-compatibility.rst#event-types
explaining the the behavior in case of multipart upload.
release notes¶
since this is a change in product behavior, there should be a note added to: https://github.com/ceph/ceph/blob/master/PendingReleaseNotes
#2 Updated by Yuval Lifshitz over 2 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 42350
#3 Updated by Yuval Lifshitz over 2 years ago
- Status changed from Fix Under Review to Pending Backport
#4 Updated by Backport Bot over 2 years ago
- Copied to Backport #51943: pacific: notifications: send only CompleteMultipartUpload notification added
#5 Updated by Backport Bot over 1 year ago
- Tags changed from notifications to notifications backport_processed