Project

General

Profile

Actions

Bug #51476

closed

src/pybind/mgr/mirroring/fs/snapshot_mirror.py: do not assume a cephfs-mirror daemon is always running

Added by Sébastien Han almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When the replication is unidirectional we cannot assume a daemon is running and the "fs snapshot mirror daemon status" command reports the following error:

debug 2021-07-01T15:16:57.451+0000 7f5289756700 -1 mgr.server reply reply (22) Invalid argument Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1345, in _handle_command
    return CLICommand.COMMANDS[cmd['prefix']].call(self, cmd, inbuf)
  File "/usr/share/ceph/mgr/mgr_module.py", line 393, in call
    return self.func(mgr, **kwargs)
  File "/usr/share/ceph/mgr/mirroring/module.py", line 103, in snapshot_mirror_daemon_status
    return self.fs_snapshot_mirror.daemon_status(fs_name)
  File "/usr/share/ceph/mgr/mirroring/fs/snapshot_mirror.py", line 764, in daemon_status
    for daemon_key in daemon_entry.get('daemons', []):
AttributeError: 'list' object has no attribute 'get'

Which is correct since no cephfs-mirror daemon is running.


Related issues 1 (0 open1 closed)

Copied to CephFS - Backport #51547: pacific: src/pybind/mgr/mirroring/fs/snapshot_mirror.py: do not assume a cephfs-mirror daemon is always runningResolvedCory SnyderActions
Actions #1

Updated by Sébastien Han almost 3 years ago

  • Pull request ID set to 42139
Actions #2

Updated by Patrick Donnelly almost 3 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Sébastien Han
  • Target version set to v17.0.0
  • Source set to Development
  • Backport set to pacific
Actions #3

Updated by Patrick Donnelly almost 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #51547: pacific: src/pybind/mgr/mirroring/fs/snapshot_mirror.py: do not assume a cephfs-mirror daemon is always running added
Actions #5

Updated by Loïc Dachary over 2 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF